public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Xu Yang <xu.yang_2@nxp.com>
To: Peter Chen <peter.chen@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	imx@lists.linux.dev, jun.li@nxp.com
Subject: Re: [PATCH v2 1/3] usb: chipidea: udc: handle USB Error Interrupt if IOC not set
Date: Thu, 26 Sep 2024 10:11:28 +0800	[thread overview]
Message-ID: <20240926021128.6blk3dsyn3ogmrjx@hippo> (raw)
In-Reply-To: <20240925124200.GA417263@nchen-desktop>

On Wed, Sep 25, 2024 at 08:42:00PM +0800, Peter Chen wrote:
> On 24-09-20 17:40:54, Xu Yang wrote:
> > As per USBSTS register description about UEI:
> > 
> >   When completion of a USB transaction results in an error condition, this
> >   bit is set by the Host/Device Controller. This bit is set along with the
> >   USBINT bit, if the TD on which the error interrupt occurred also had its
> >   interrupt on complete (IOC) bit set.
> > 
> > UI is set only when IOC set. Add checking UEI to fix miss call
> > isr_tr_complete_handler() when IOC have not set and transfer error happen.
> > 
> > Fixes: 26c696c678c4 ("USB: Chipidea: rename struct ci13xxx variables from udc to ci")
> > Cc: stable@vger.kernel.org
> > Acked-by: Peter Chen <peter.chen@kernel.com>
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> 
> Since this driver has used more than ten years for many vendors, I am
> not sure if will affect others or not. Please do not CC stable tree, or
> send it to stable tree when this patch at master more than half an year
> without no one report issue.

Okay. I'm going to remove fix tag and stable maillist in v3.

Thanks,
Xu Yang

      reply	other threads:[~2024-09-26  2:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20  9:40 [PATCH v2 1/3] usb: chipidea: udc: handle USB Error Interrupt if IOC not set Xu Yang
2024-09-20  9:40 ` [PATCH v2 2/3] usb: chipidea: udc: improve dTD link logic Xu Yang
2024-09-25 12:43   ` Peter Chen
2024-09-20  9:40 ` [PATCH v2 3/3] usb: chipidea: udc: improve error recovery for ISO transfer Xu Yang
2024-09-25 12:44   ` Peter Chen
2024-09-25 12:42 ` [PATCH v2 1/3] usb: chipidea: udc: handle USB Error Interrupt if IOC not set Peter Chen
2024-09-26  2:11   ` Xu Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240926021128.6blk3dsyn3ogmrjx@hippo \
    --to=xu.yang_2@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=jun.li@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox