Re: [PATCH] r8152: Add mac address pass-thru for lg laptops

[kernel test robot <lkp@intel.com>]

Hi mike.seo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on westeri-thunderbolt/next]
[also build test WARNING on linus/master v6.12-rc1 next-20240930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/mike-seo/r8152-Add-mac-address-pass-thru-for-lg-laptops/20240930-144644
base:   https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next
patch link:    https://lore.kernel.org/r/ZvpImQ_8jh5fyorl%40mikeseo-0-1
patch subject: [PATCH] r8152: Add mac address pass-thru for lg laptops
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241001/202410010249.Gzfm9BQC-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241001/202410010249.Gzfm9BQC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410010249.Gzfm9BQC-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In function 'rtl8152_supports_lg_macpassthru',
       inlined from 'rtl8152_probe_once.isra' at drivers/net/usb/r8152.c:9881:23:
>> drivers/net/usb/r8152.c:9800:14: warning: argument 2 null where non-null expected [-Wnonnull]
    9800 |         if (!strncmp("LG Electronics", board, sizeof("LG Electronics"))) {
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/usb/r8152.c:9800:14: note: in a call to built-in function '__builtin_strcmp'


vim +9800 drivers/net/usb/r8152.c

  9793	
  9794	static bool rtl8152_supports_lg_macpassthru(struct usb_device *udev)
  9795	{
  9796		int product_id = le16_to_cpu(udev->descriptor.idProduct);
  9797		int vendor_id = le16_to_cpu(udev->descriptor.idVendor);
  9798		const char *board = dmi_get_system_info(DMI_BOARD_VENDOR);
  9799	
> 9800		if (!strncmp("LG Electronics", board, sizeof("LG Electronics"))) {
  9801			if (vendor_id == VENDOR_ID_REALTEK && product_id == 0x8153)
  9802				return 1;
  9803		}
  9804		return 0;
  9805	}
  9806	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki