From: "Michał Pecio" <michal.pecio@gmail.com>
To: islituo@gmail.com
Cc: baijiaju1990@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
mathias.nyman@intel.com
Subject: Re: [PATCH] usb: xhci: fix a possible null-pointer dereference in xhci_setup_device()
Date: Wed, 2 Oct 2024 14:14:54 +0200 [thread overview]
Message-ID: <20241002141454.6efded4e@foxbook> (raw)
In-Reply-To: <20241002120439.077afc90@foxbook>
> By the way, is your analyzer not finding the issue that any call to
> xhci_mem_cleanup() wakes up everybody waiting on the command queue and
> then sets a bunch of things (including xhci->dcbaa) to NULL shortly
> thereafter? This race looks like it shouldn't be harder to detect than
> the things you are doing already.
Actually, I think neither the above nor the issue you reported is a
problem at all, because xhci_setup_device() checks if command->status
is COMP_COMMAND_ABORTED and returns early in this case. At a quick
glance, other command handlers do the same.
This status code is always assigned by xhci_cleanup_command_queue().
Regards,
Michal
prev parent reply other threads:[~2024-10-02 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 19:45 [PATCH] usb: xhci: fix a possible null-pointer dereference in xhci_setup_device() Tuo Li
2024-10-02 10:04 ` Michał Pecio
2024-10-02 12:14 ` Michał Pecio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002141454.6efded4e@foxbook \
--to=michal.pecio@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=islituo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox