From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC9B320FAA3; Fri, 4 Oct 2024 13:36:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728048974; cv=none; b=Em+Km3ocNBGCixLgUb5FCh7x91TX9Nen7GjjT8ROlPB1e+4CEIO/5EuF1J07C+YX483VZp3PbI6wo7c/ySuJXgSRHIRfOjcL7648ta0EU2sLFwWk3rP+v+VyqV2tp+quXQiFiw/C3mqxsJ2rutlXdRHPmGe/JhnwmqJATq/qHw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728048974; c=relaxed/simple; bh=tieUOrrAcHsu5cgnJ00NmvfVHIsqPmrga/Ha+IsjexM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QkomGclugMozv5JHT+yBn2bH8+S7zHa3ms4AypwNNelCJ4rmyqiJwrFfZPmDCQKaU4xPiPnln7NrHTgjxPx0hGk26LT1dblQJ/a5D3bVsnyukpGpfRz2/88tDb6K1p+VkGqehvjR+/EyQyQsvJv1scP3WAuFf/lUblEJ8qoC1cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MsFLmbzp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MsFLmbzp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7E59C567CE; Fri, 4 Oct 2024 13:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728048974; bh=tieUOrrAcHsu5cgnJ00NmvfVHIsqPmrga/Ha+IsjexM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MsFLmbzpKz3CPAO2qC/lphqcsDHvH1td07P6Wb8X/r5qby72k6jzQF26ZP0oiOSkk Hfq3OSufyYF2TxFuuvVZEBrgXH5+Wdv9wQ6zTUtjcL3PkYsoR9HWpDJV6ehWnsXi6C +qUzWpaHALDhjNWfV9JojWvT1EaSLHuUX3z6bUhE= Date: Fri, 4 Oct 2024 15:36:11 +0200 From: Greg KH To: Radhey Shyam Pandey Cc: mka@chromium.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, wentong.wu@intel.com, sakari.ailus@linux.intel.com, javier.carrasco@wolfvision.net, matthias@kaehlcke.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, git@amd.com Subject: Re: [PATCH v2] usb: misc: onboard_usb_dev: introduce new config symbol for usb5744 SMBus support Message-ID: <2024100442-yoyo-fifth-2125@gregkh> References: <1727529992-476088-1-git-send-email-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1727529992-476088-1-git-send-email-radhey.shyam.pandey@amd.com> On Sat, Sep 28, 2024 at 06:56:32PM +0530, Radhey Shyam Pandey wrote: > Introduce new kernel config symbol for Microchip usb5744 SMBus programming > support. Since usb5744 i2c initialization routine uses i2c SMBus APIs these > APIs should only be invoked when kernel has I2C support. This new kernel > config describes the dependency on I2C kernel support and fix the below > build issues when USB_ONBOARD_DEV=y and CONFIG_I2C=m. > > riscv64-linux-ld: drivers/usb/misc/onboard_usb_dev.o: > undefined reference to `i2c_find_device_by_fwnode' > drivers/usb/misc/onboard_usb_dev.c:408:(.text+0xb24): undefined > reference to `i2c_smbus_write_block_data' > > > Parsing of the i2c-bus bus handle is not put under usb5744 kernel config > check as the intention is to report an error when DT is configured for > usb5744 SMBus support and kernel has USB_ONBOARD_DEV_USB5744 disabled. > > Fixes: 6782311d04df ("usb: misc: onboard_usb_dev: add Microchip usb5744 SMBus programming support") > Signed-off-by: Radhey Shyam Pandey > Suggested-by: Matthias Kaehlcke > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202409140539.3Axwv38m-lkp@intel.com/ > Acked-by: Matthias Kaehlcke > --- > Changes for v2: > - As suggested by Greg drop default 'y' and instead describe the > constraints in the kconfig description. > --- > drivers/usb/misc/Kconfig | 12 ++++++++++++ > drivers/usb/misc/onboard_usb_dev.c | 6 ++++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 50b86d531701..6497c4e81e95 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -331,3 +331,15 @@ config USB_ONBOARD_DEV > this config will enable the driver and it will automatically > match the state of the USB subsystem. If this driver is a > module it will be called onboard_usb_dev. > + > +config USB_ONBOARD_DEV_USB5744 > + bool "Onboard USB Microchip usb5744 hub with SMBus support" > + depends on (USB_ONBOARD_DEV && I2C=y) || (USB_ONBOARD_DEV=m && I2C=m) > + help > + Say Y here if you want to support onboard USB Microchip usb5744 > + hub that requires SMBus initialization. > + > + This options enables usb5744 i2c default initialization sequence > + during hub start-up configuration stage. It is must to enable this > + option on AMD Kria KR260 Robotics Starter Kit as this hub is > + connected to USB-SD converter which mounts the root filesystem. With this applied I get the following build warning: WARNING: unmet direct dependencies detected for MODVERSIONS Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y] Selected by [y]: - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=n] || GCC_PLUGINS [=y]) && MODULES [=y] WARNING: unmet direct dependencies detected for MODVERSIONS Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y] Selected by [y]: - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=n] || GCC_PLUGINS [=y]) && MODULES [=y] WARNING: unmet direct dependencies detected for MODVERSIONS Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y] Selected by [y]: - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=n] || GCC_PLUGINS [=y]) && MODULES [=y] Which is odd. It's one extra "unmet direct ..." message than normal for now, so something in this commit is not working properly. Can you fix this up and send a new version? thanks, greg k-h