From: Guan-Yu Lin <guanyulin@google.com>
To: Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, stern@rowland.harvard.edu,
yajun.deng@linux.dev, sumit.garg@linaro.org, kekrby@gmail.com,
oneukum@suse.com, dianders@chromium.org, perex@perex.cz,
tiwai@suse.com, niko.mauno@vaisala.com, andreyknvl@gmail.com,
christophe.jaillet@wanadoo.fr, tj@kernel.org,
stanley_chang@realtek.com, quic_jjohnson@quicinc.com,
ricardo@marliere.net
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, badhri@google.com,
albertccwang@google.com, quic_wcheng@quicinc.com,
pumahsu@google.com, Guan-Yu Lin <guanyulin@google.com>
Subject: [PATCH v5 3/5] usb: add apis for sideband usage tracking
Date: Mon, 14 Oct 2024 08:50:27 +0000 [thread overview]
Message-ID: <20241014085816.1401364-4-guanyulin@google.com> (raw)
In-Reply-To: <20241014085816.1401364-1-guanyulin@google.com>
Introduce sb_usage_count and corresponding apis to track sideband usage
on each USB device. A sideband refers to the co-processor that accesses
the usb_device via shared control on the same USB host controller. To
optimize power usage, it's essential to monitor whether ther sideband is
actively using the USB device. This information is vital when
determining if a USB device can be safely suspended during system power
state transitions.
Signed-off-by: Guan-Yu Lin <guanyulin@google.com>
---
drivers/usb/core/driver.c | 53 +++++++++++++++++++++++++++++++++++++++
include/linux/usb.h | 13 ++++++++++
2 files changed, 66 insertions(+)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 0c3f12daac79..e713cf9b3dd2 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -1673,6 +1673,59 @@ void usb_disable_autosuspend(struct usb_device *udev)
}
EXPORT_SYMBOL_GPL(usb_disable_autosuspend);
+/**
+ * usb_sideband_get - increment the sb_usage_count of a USB device
+ * @udev: the USB device to increment its sb_usage_count
+ *
+ * Incrementing the sb_usage_count of a usb_device indicates that a sideband is
+ * currently using the device; that is, another entity is actively handling USB
+ * transfers. This information allows the USB driver to adjust its power
+ * management policy based on sideband activity.
+ */
+void usb_sideband_get(struct usb_device *udev)
+{
+ refcount_inc(&udev->sb_usage_count);
+}
+EXPORT_SYMBOL_GPL(usb_sideband_get);
+
+/**
+ * usb_sideband_put - drop the sb_usage_count of a USB device
+ * @udev: the USB device to drop its sb_usage_count
+ *
+ * The inverse operation of usb_sideband_get, which drops the sb_usage_count of
+ * a USB device. This information allows the USB driver to adjust its power
+ * management policy based on sideband activity.
+ */
+void usb_sideband_put(struct usb_device *udev)
+{
+ refcount_dec(&udev->sb_usage_count);
+}
+EXPORT_SYMBOL_GPL(usb_sideband_put);
+
+/**
+ * usb_sideband_check - check sideband activities on a USB device
+ * @udev: the USB device to check its sideband activity.
+ *
+ * Check if there are any sideband activity on the USB device right now. This
+ * information could be used for power management or other forms or resource
+ * management.
+ *
+ * Returns true on any active sideband existence, false otherwise
+ */
+bool usb_sideband_check(struct usb_device *udev)
+{
+ struct usb_device *child;
+ int port1;
+
+ usb_hub_for_each_child(udev, port1, child) {
+ if (usb_sideband_check(child))
+ return true;
+ }
+
+ return !!refcount_read(&udev->sb_usage_count);
+}
+EXPORT_SYMBOL_GPL(usb_sideband_check);
+
/**
* usb_autosuspend_device - delayed autosuspend of a USB device and its interfaces
* @udev: the usb_device to autosuspend
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 672d8fc2abdb..37a36750a851 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -645,6 +645,7 @@ struct usb3_lpm_parameters {
* parent->hub_delay + wHubDelay + tTPTransmissionDelay (40ns)
* Will be used as wValue for SetIsochDelay requests.
* @use_generic_driver: ask driver core to reprobe using the generic driver.
+ * @sb_usage_count: number of active sideband accessing this usb device.
*
* Notes:
* Usbcore drivers should not set usbdev->state directly. Instead use
@@ -731,6 +732,8 @@ struct usb_device {
u16 hub_delay;
unsigned use_generic_driver:1;
+
+ refcount_t sb_usage_count;
};
#define to_usb_device(__dev) container_of_const(__dev, struct usb_device, dev)
@@ -798,6 +801,9 @@ static inline int usb_acpi_port_lpm_incapable(struct usb_device *hdev, int index
#ifdef CONFIG_PM
extern void usb_enable_autosuspend(struct usb_device *udev);
extern void usb_disable_autosuspend(struct usb_device *udev);
+extern void usb_sideband_get(struct usb_device *udev);
+extern void usb_sideband_put(struct usb_device *udev);
+extern bool usb_sideband_check(struct usb_device *udev);
extern int usb_autopm_get_interface(struct usb_interface *intf);
extern void usb_autopm_put_interface(struct usb_interface *intf);
@@ -818,6 +824,13 @@ static inline int usb_enable_autosuspend(struct usb_device *udev)
static inline int usb_disable_autosuspend(struct usb_device *udev)
{ return 0; }
+static inline int usb_sideband_get(struct usb_device *udev)
+{ return 0; }
+static inline int usb_sideband_put(struct usb_device *udev)
+{ return 0; }
+static inline bool usb_sideband_check(struct usb_device *udev)
+{ return false; }
+
static inline int usb_autopm_get_interface(struct usb_interface *intf)
{ return 0; }
static inline int usb_autopm_get_interface_async(struct usb_interface *intf)
--
2.47.0.rc1.288.g06298d1525-goog
next prev parent reply other threads:[~2024-10-14 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 8:50 [PATCH v5 0/5] Support system sleep with offloaded usb transfers Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 1/5] usb: dwc3: separate dev_pm_ops for each pm_event Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 2/5] usb: xhci-plat: " Guan-Yu Lin
2024-10-14 8:50 ` Guan-Yu Lin [this message]
2024-10-14 8:50 ` [PATCH v5 4/5] xhci: sideband: add api to trace sideband usage Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 5/5] usb: host: enable sideband transfer during system sleep Guan-Yu Lin
2024-10-14 9:21 ` Greg KH
2024-10-14 16:06 ` Guan-Yu Lin
2024-10-14 13:08 ` Mathias Nyman
2024-10-14 16:19 ` Guan-Yu Lin
2024-10-14 15:56 ` Alan Stern
2024-10-14 15:59 ` Alan Stern
2024-10-15 3:56 ` Guan-Yu Lin
2024-10-15 14:43 ` Alan Stern
2024-10-16 7:40 ` Guan-Yu Lin
2024-10-16 14:45 ` Alan Stern
2024-10-18 11:59 ` Guan-Yu Lin
2024-10-18 14:41 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014085816.1401364-4-guanyulin@google.com \
--to=guanyulin@google.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=albertccwang@google.com \
--cc=andreyknvl@gmail.com \
--cc=badhri@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kekrby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=niko.mauno@vaisala.com \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=pumahsu@google.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=ricardo@marliere.net \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=sumit.garg@linaro.org \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox