From: Greg KH <gregkh@linuxfoundation.org>
To: Dingyan Li <18500469033@163.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: storage: use US_BULK_FLAG_OUT instead of constant values
Date: Sun, 20 Oct 2024 08:17:16 +0200 [thread overview]
Message-ID: <2024102056-yearly-caregiver-d684@gregkh> (raw)
In-Reply-To: <20241019160822.6862-1-18500469033@163.com>
On Sun, Oct 20, 2024 at 12:08:22AM +0800, Dingyan Li wrote:
> Macros with good names offer better readability. Besides, fix an error
> in the comments. In the flags, direction is in bit 7 instead of bit 0.
That means this should be at least 2 different patches please.
Remember, each change only does one logical thing.
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-20 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 16:08 [PATCH v1] usb: storage: use US_BULK_FLAG_OUT instead of constant values Dingyan Li
2024-10-20 6:17 ` Greg KH [this message]
2024-10-20 7:23 ` [PATCH v2] " Dingyan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102056-yearly-caregiver-d684@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=18500469033@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox