From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Chung <tony467913@gmail.com>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: mos7840: Add more kinds of baud rate
Date: Tue, 22 Oct 2024 09:10:57 +0200 [thread overview]
Message-ID: <2024102207-unmixed-caregiver-b9eb@gregkh> (raw)
In-Reply-To: <20241022070127.66083-1-tony467913@gmail.com>
On Tue, Oct 22, 2024 at 03:01:28PM +0800, Tony Chung wrote:
> This patch adds more kinds of baud rate support.
> also fix all the coding style errors & warnings shown by /scripts/checkpatch.pl
Hint, when you say "also" in a patch changelog, that's a huge hint you
should split this up into multiple changes.
Remember, each patch should do only one logical thing. Do not mix bug
fixes or new features or coding style changes in the same commit.
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-22 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 7:01 [PATCH] usb: serial: mos7840: Add more kinds of baud rate Tony Chung
2024-10-22 7:10 ` Greg KH [this message]
2024-10-22 9:40 ` [PATCH] usb: serial: mos7840: Add more kinds of baud rate support Tony Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102207-unmixed-caregiver-b9eb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony467913@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox