public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: huanglei814 <huanglei814@163.com>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, huanglei <huanglei@kylinos.cn>
Subject: Re: [PATCH v3] usb: core: adds support for PM control of specific USB dev skip suspend.
Date: Tue, 22 Oct 2024 11:39:12 +0200	[thread overview]
Message-ID: <2024102239-stainable-favored-558b@gregkh> (raw)
In-Reply-To: <20241022090905.9806-1-huanglei814@163.com>

On Tue, Oct 22, 2024 at 05:09:05PM +0800, huanglei814 wrote:
> From: huanglei <huanglei@kylinos.cn>
> 
> All USB devices are brought into suspend power state after system suspend.
> It is desirable for some specific manufacturers buses to keep their devices
> in normal state even after system suspend.
> 
> v2: Change to bool type for skip_suspend.
> v3: Rebase and update commit message.

As per the documentation, this needs to go below the --- line.  Also,
you changed more than just the bool type in v2 :(

Please fix up and do a v4 after waiting a while for others to review
this.

thanks,

greg k-h

  reply	other threads:[~2024-10-22  9:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  9:09 [PATCH v3] usb: core: adds support for PM control of specific USB dev skip suspend huanglei814
2024-10-22  9:39 ` Greg KH [this message]
2024-10-22 13:14 ` Krzysztof Kozlowski
2024-10-23  3:32   ` huanglei
2024-10-23  6:09     ` Krzysztof Kozlowski
2024-10-22 15:59 ` Alan Stern
2024-10-23  3:43   ` huanglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024102239-stainable-favored-558b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=huanglei814@163.com \
    --cc=huanglei@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox