Re: [PATCH] usb: serial: mos7840: Fix coding style warnings

[kernel test robot <lkp@intel.com>]

Hi Tony,

kernel test robot noticed the following build errors:

[auto build test ERROR on johan-usb-serial/usb-next]
[also build test ERROR on johan-usb-serial/usb-linus usb/usb-testing usb/usb-next usb/usb-linus tty/tty-testing tty/tty-next tty/tty-linus linus/master v6.12-rc4 next-20241024]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tony-Chung/usb-serial-mos7840-Fix-coding-style-warnings/20241023-171615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next
patch link:    https://lore.kernel.org/r/20241023091414.18098-1-tony467913%40gmail.com
patch subject: [PATCH] usb: serial: mos7840: Fix coding style warnings
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241025/202410251501.9hTgSYCH-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241025/202410251501.9hTgSYCH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410251501.9hTgSYCH-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/usb/serial/mos7840.c: In function 'mos7840_write':
>> drivers/usb/serial/mos7840.c:923:39: warning: missing terminating " character
     923 |                 dev_err_console(port, "%s - usb_submit_urb(write bulk) failed
         |                                       ^
   drivers/usb/serial/mos7840.c:924:43: warning: missing terminating " character
     924 |                         with status = %d\n", __func__, status);
         |                                           ^
>> drivers/usb/serial/mos7840.c:1832:23: error: unterminated argument list invoking macro "dev_err_console"
    1832 | MODULE_LICENSE("GPL");
         |                       ^
>> drivers/usb/serial/mos7840.c:923:17: error: 'dev_err_console' undeclared (first use in this function); did you mean 'dev_err_probe'?
     923 |                 dev_err_console(port, "%s - usb_submit_urb(write bulk) failed
         |                 ^~~~~~~~~~~~~~~
         |                 dev_err_probe
   drivers/usb/serial/mos7840.c:923:17: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/usb/serial/mos7840.c:923:32: error: expected ';' at end of input
     923 |                 dev_err_console(port, "%s - usb_submit_urb(write bulk) failed
         |                                ^
         |                                ;
   ......
>> drivers/usb/serial/mos7840.c:923:17: error: expected declaration or statement at end of input
     923 |                 dev_err_console(port, "%s - usb_submit_urb(write bulk) failed
         |                 ^~~~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:923:17: error: expected declaration or statement at end of input
>> drivers/usb/serial/mos7840.c:887:25: error: label 'exit' used but not defined
     887 |                         goto exit;
         |                         ^~~~
>> drivers/usb/serial/mos7840.c:856:13: warning: variable 'bytes_sent' set but not used [-Wunused-but-set-variable]
     856 |         int bytes_sent = 0;
         |             ^~~~~~~~~~
   drivers/usb/serial/mos7840.c: At top level:
>> drivers/usb/serial/mos7840.c:849:12: warning: 'mos7840_write' defined but not used [-Wunused-function]
     849 | static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
         |            ^~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:820:21: warning: 'mos7840_write_room' defined but not used [-Wunused-function]
     820 | static unsigned int mos7840_write_room(struct tty_struct *tty)
         |                     ^~~~~~~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:795:12: warning: 'mos7840_break' defined but not used [-Wunused-function]
     795 | static int mos7840_break(struct tty_struct *tty, int break_state)
         |            ^~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:764:13: warning: 'mos7840_close' defined but not used [-Wunused-function]
     764 | static void mos7840_close(struct usb_serial_port *port)
         |             ^~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:737:21: warning: 'mos7840_chars_in_buffer' defined but not used [-Wunused-function]
     737 | static unsigned int mos7840_chars_in_buffer(struct tty_struct *tty)
         |                     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:516:12: warning: 'mos7840_open' defined but not used [-Wunused-function]
     516 | static int mos7840_open(struct tty_struct *tty, struct usb_serial_port *port)
         |            ^~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:410:13: warning: 'mos7840_led_flag_off' defined but not used [-Wunused-function]
     410 | static void mos7840_led_flag_off(struct timer_list *t)
         |             ^~~~~~~~~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:400:13: warning: 'mos7840_led_off' defined but not used [-Wunused-function]
     400 | static void mos7840_led_off(struct timer_list *t)
         |             ^~~~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:391:13: warning: 'mos7840_set_led_sync' defined but not used [-Wunused-function]
     391 | static void mos7840_set_led_sync(struct usb_serial_port *port, __u16 reg,
         |             ^~~~~~~~~~~~~~~~~~~~
>> drivers/usb/serial/mos7840.c:337:13: warning: 'mos7840_dump_serial_port' defined but not used [-Wunused-function]
     337 | static void mos7840_dump_serial_port(struct usb_serial_port *port,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/dev_err_console +1832 drivers/usb/serial/mos7840.c

3f5429746d91f2 Paul B Schroeder 2006-08-31  1830  
3f5429746d91f2 Paul B Schroeder 2006-08-31  1831  MODULE_DESCRIPTION(DRIVER_DESC);
3f5429746d91f2 Paul B Schroeder 2006-08-31 @1832  MODULE_LICENSE("GPL");

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki