linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Rick <rick@581238.xyz>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	Sanath.S@amd.com, christian@heusel.eu, fabian@fstab.de,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	regressions@lists.linux.dev, stable@vger.kernel.org
Subject: Re: Dell WD19TB Thunderbolt Dock not working with kernel > 6.6.28-1
Date: Wed, 30 Oct 2024 11:06:25 +0200	[thread overview]
Message-ID: <20241030090625.GS275077@black.fi.intel.com> (raw)
In-Reply-To: <2c27683e-aca8-48d0-9c63-f0771c6a7107@581238.xyz>

Hi Rick,

On Wed, Oct 30, 2024 at 08:11:30AM +0100, Rick wrote:
> Hi Mika,
> 
> Thank you for your email.
> 
> On 28-10-2024 09:18, Mika Westerberg wrote:
> > 
> > I still see similar issue even with the v6.9 kernel. The link goes up an
> > down unexpectly.
> > 
> > I wonder if you could try to take traces of the control channel traffic?
> > I suggest to use v6.11 kernel because it should have all the tracing
> > bits added then install tbtools [1] and follow the steps here:
> > 
> >    https://github.com/intel/tbtools?tab=readme-ov-file#tracing
> > 
> > Then provide both full dmesg and the trace output. That hopefully shows
> > if some of the access we are doing in the Linux side is causing the link
> > to to drop. Let me know if you need more detailed instructions.
> > 
> > Also please drop the "thunderbolt.host_reset=0" from the command line as
> > that did not help, so it is not needed.
> 
> Dropped thank you.
> 
> > 
> > [1] https://github.com/intel/tbtools
> 
> tbtrace on 6.11.5:
> https://gist.github.com/ricklahaye/69776e9c39fd30a80e2adb6156bdb42d
> dmesg on 6.11.5:
> https://gist.github.com/ricklahaye/8588450725695a0bd45799d3d66c7aff

Thanks! I suspect there is something we do when we read the sideband
that makes the device router to "timeout" and retry the link
establishment. There is also the failure when USB 3.x tunnel is created
but we can look that after we figure out the connection issue.

Looking at the trace we are still polling for retimers when we see the
unplug:

[   48.684078] tb_tx Read Request Domain 0 Route 0 Adapter 3 / Lane
               0x00/---- 0x00000000 0b00000000 00000000 00000000 00000000 .... Route String High
               0x01/---- 0x00000000 0b00000000 00000000 00000000 00000000 .... Route String Low
               0x02/---- 0x02182091 0b00000010 00011000 00100000 10010001 .... 
                 [00:12]       0x91 Address
                 [13:18]        0x1 Read Size
                 [19:24]        0x3 Adapter Num
                 [25:26]        0x1 Configuration Space (CS) → Adapter Configuration Space
                 [27:28]        0x0 Sequence Number (SN)
[   48.684339] tb_rx Read Response Domain 0 Route 0 Adapter 3 / Lane
               0x00/---- 0x80000000 0b10000000 00000000 00000000 00000000 .... Route String High
               0x01/---- 0x00000000 0b00000000 00000000 00000000 00000000 .... Route String Low
               0x02/---- 0x02182091 0b00000010 00011000 00100000 10010001 .... 
                 [00:12]       0x91 Address
                 [13:18]        0x1 Read Size
                 [19:24]        0x3 Adapter Num
                 [25:26]        0x1 Configuration Space (CS) → Adapter Configuration Space
                 [27:28]        0x0 Sequence Number (SN)
               0x03/0091 0x81320408 0b10000001 00110010 00000100 00001000 .2.. PORT_CS_1
                 [00:07]        0x8 Address
                 [08:15]        0x4 Length
                 [16:18]        0x2 Target
                 [20:23]        0x3 Re-timer Index
                 [24:24]        0x1 WnR
                 [25:25]        0x0 No Response (NR)
                 [26:26]        0x0 Result Code (RC)
                 [31:31]        0x1 Pending (PND)
[   48.691410] tb_event Hot Plug Event Packet Domain 0 Route 0 Adapter 3 / Lane
               0x00/---- 0x80000000 0b10000000 00000000 00000000 00000000 .... Route String High
               0x01/---- 0x00000000 0b00000000 00000000 00000000 00000000 .... Route String Low
               0x02/---- 0x80000003 0b10000000 00000000 00000000 00000011 .... 
                 [00:05]        0x3 Adapter Num
                 [31:31]        0x1 UPG
[   48.691414] thunderbolt 0000:00:0d.2: acking hot unplug event on 0:3

Taking this into account and also the fact that your previous email you
say that v6.9 works and v6.10 does not, I wonder if you could first try
just to revert:

  c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")

and see if that helps with the connection issue? If it does then can you
take full dmesg and the trace again and with me so I can look at the USB
tunnel issue too?

  reply	other threads:[~2024-10-30  9:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 12:13 Dell WD19TB Thunderbolt Dock not working with kernel > 6.6.28-1 rick
2024-10-22 12:55 ` Mario Limonciello
2024-10-22 15:44   ` Rick
2024-10-22 16:10     ` Mika Westerberg
2024-10-22 16:25       ` Mario Limonciello
2024-10-22 17:06       ` Rick
2024-10-23  6:10         ` Mika Westerberg
2024-10-25 10:20           ` Rick
2024-10-28  8:18             ` Mika Westerberg
2024-10-30  7:11               ` Rick
2024-10-30  9:06                 ` Mika Westerberg [this message]
2024-11-01 12:57                   ` Rick
2024-11-04  6:36                     ` Mika Westerberg
2024-11-04 18:04                       ` Rick
2024-11-05  6:31                         ` Mika Westerberg
2024-11-05  8:12                           ` Rick
     [not found] <CAPX310gmJeYhE2C6-==rKSDh6wAmoR8R5-pjEOgYD3AP+Si+0w@mail.gmail.com>
2024-09-23  6:45 ` Greg KH
2024-09-24  6:58   ` Fabian Stäber
2024-10-07 16:49     ` Fabian Stäber
2024-10-07 17:13       ` Linux regression tracking (Thorsten Leemhuis)
2024-10-07 17:21       ` Christian Heusel
2024-10-07 17:33         ` Mario Limonciello
2024-10-08 16:56           ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030090625.GS275077@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=Sanath.S@amd.com \
    --cc=christian@heusel.eu \
    --cc=fabian@fstab.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=regressions@lists.linux.dev \
    --cc=rick@581238.xyz \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).