From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Lukas Wunner <lukas@wunner.de>,
Andreas Noever <andreas.noever@gmail.com>,
Rick Lahaye <rick@581238.xyz>,
Mario Limonciello <mario.limonciello@amd.com>,
Sanath.S@amd.com, christian@heusel.eu, fabian@fstab.de,
regressions@lists.linux.dev
Subject: Re: [PATCH] thunderbolt: Fix connection issue with Pluggable UD-4VPD dock
Date: Tue, 5 Nov 2024 11:24:12 +0200 [thread overview]
Message-ID: <20241105092412.GF275077@black.fi.intel.com> (raw)
In-Reply-To: <2024110514-unashamed-amenity-6b9c@gregkh>
Hi Greg,
On Tue, Nov 05, 2024 at 10:17:43AM +0100, Greg KH wrote:
> On Tue, Nov 05, 2024 at 10:53:01AM +0200, Mika Westerberg wrote:
> > Rick reported that his Pluggable USB4 dock does not work anymore after
> > 6.6.28 kernel.
> >
> > It looks like commit c6ca1ac9f472 ("thunderbolt: Increase sideband
> > access polling delay") makes the device router enumeration happen later
> > than what might be expected by the dock (although there is no such limit
> > in the USB4 spec) which probably makes it assume there is something
> > wrong with the high-speed link and reset it. After the link is reset the
> > same issue happens again and again.
> >
> > For this reason lower the sideband access delay from 5ms to 1ms. This
> > seems to work fine according to Rick's testing.
> >
> > Reported-by: Rick Lahaye <rick@581238.xyz>
> > Closes: https://lore.kernel.org/linux-usb/000f01db247b$d10e1520$732a3f60$@581238.xyz/
> > Tested-by: Rick Lahaye <rick@581238.xyz>
> > Fixes: c6ca1ac9f472 ("thunderbolt: Increase sideband access polling delay")
>
> This commit is not in the 6.6.y tree, it only showed up in 6.10.y, so
> how does this resolve an issue in the 6.6.y tree?
This refers to a mainline commit that caused the issue. The 6.6.28 is
the kernel version Rick used where it still worked. In other words, this
is not a backport of a fix but a fix intented to the mainline ;-) I hope
this clarifies. I can adjust the commit message if needed.
next prev parent reply other threads:[~2024-11-05 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 8:53 [PATCH] thunderbolt: Fix connection issue with Pluggable UD-4VPD dock Mika Westerberg
2024-11-05 9:17 ` Greg KH
2024-11-05 9:24 ` Mika Westerberg [this message]
2024-11-05 9:50 ` Greg KH
2024-11-05 9:56 ` Mika Westerberg
2024-11-05 10:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105092412.GF275077@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Sanath.S@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=christian@heusel.eu \
--cc=fabian@fstab.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=regressions@lists.linux.dev \
--cc=rick@581238.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox