public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc: linux-usb@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v3 1/3] usb: misc: ljca: move usb_autopm_put_interface() after wait for response
Date: Thu, 7 Nov 2024 10:03:56 +0100	[thread overview]
Message-ID: <2024110710-duckbill-commodity-d1b5@gregkh> (raw)
In-Reply-To: <ZyyAZaUNJ0kCEHG7@linux.intel.com>

On Thu, Nov 07, 2024 at 09:55:01AM +0100, Stanislaw Gruszka wrote:
> On Thu, Nov 07, 2024 at 09:16:01AM +0100, Greg KH wrote:
> > On Thu, Nov 07, 2024 at 08:37:16AM +0100, Stanislaw Gruszka wrote:
> > > Do not mark interface as ready to suspend when we are still waiting
> > > for response messages from the device.
> > > 
> > > Fixes: acd6199f195d ("usb: Add support for Intel LJCA device")
> > > Cc: stable@vger.kernel.org
> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > > Tested-by: Hans de Goede <hdegoede@redhat.com> # ThinkPad X1 Yoga Gen 8, ov2740
> > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > > ---
> > > v2: fix handing error of usb_autopm_get_interface(),
> > >     add R-b, T-b tags from Hans
> > > v3: add A-b tag from Sakari
> > > 
> > >  drivers/usb/misc/usb-ljca.c | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > For some reason you aren't sending this to the usb maintainer to be
> > applied, oh well...
> 
> Sorry, I thought sending patches to the mailing list is sufficient
> to get them applied. 

Please work with the Intel internal group to get their approval and
review before sending out your next round of patches for this, as they
know how to catch trivial stuff like this before forcing others to point
it out :)

thanks,

greg k-h

  reply	other threads:[~2024-11-07  9:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07  7:37 [PATCH v3 1/3] usb: misc: ljca: move usb_autopm_put_interface() after wait for response Stanislaw Gruszka
2024-11-07  7:37 ` [PATCH v3 2/3] usb: misc: ljca: set small runtime autosuspend delay Stanislaw Gruszka
2024-11-07  7:37 ` [PATCH v3 3/3] usb: misc: ljca: print firmware version Stanislaw Gruszka
2024-11-07  8:37   ` Greg KH
2024-11-07  9:27     ` Stanislaw Gruszka
2024-11-11 11:08       ` Stanislaw Gruszka
2024-11-07  8:16 ` [PATCH v3 1/3] usb: misc: ljca: move usb_autopm_put_interface() after wait for response Greg KH
2024-11-07  8:55   ` Stanislaw Gruszka
2024-11-07  9:03     ` Greg KH [this message]
2024-11-07  9:32       ` Sakari Ailus
2024-11-07  9:39         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024110710-duckbill-commodity-d1b5@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stanislaw.gruszka@linux.intel.com \
    --cc=wentong.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox