Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

Ira Weiny
2024-11-04T14:57:24Z

Thomas Weißschuh wrote:
> The is_bin_visible() callbacks should not modify the struct
> bin_attribute passed as argument.
> Enforce this by marking the argument as const.
>
> As there are not many callback implementers perform this change
> throughout the tree at once.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/cxl/port.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> drivers/infiniband/hw/qib/qib_sysfs.c | 2 +-
> drivers/mtd/spi-nor/sysfs.c | 2 +-
> drivers/nvmem/core.c | 3 ++-
> drivers/pci/pci-sysfs.c | 2 +-
> drivers/pci/vpd.c | 2 +-
> drivers/platform/x86/amd/hsmp.c | 2 +-
> drivers/platform/x86/intel/sdsi.c | 2 +-
> drivers/scsi/scsi_sysfs.c | 2 +-
> drivers/usb/core/sysfs.c | 2 +-
> include/linux/sysfs.h | 30 +++++++++++++++---------------
> 12 files changed, 27 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/cxl/port.c b/drivers/cxl/port.c
> index 9dc394295e1fcd1610813837b2f515b66995eb25..24041cf85cfbe6c54c467ac325e48c775562b938 100644
> --- a/drivers/cxl/port.c
> +++ b/drivers/cxl/port.c
> @@ -173,7 +173,7 @@ static ssize_t CDAT_read(struct file *filp, struct kobject *kobj,
> static BIN_ATTR_ADMIN_RO(CDAT, 0);
>
> static umode_t cxl_port_bin_attr_is_visible(struct kobject *kobj,
> - struct bin_attribute *attr, int i)
> + const struct bin_attribute *attr, int i)
> {
> struct device *dev = kobj_to_dev(kobj);
> struct cxl_port *port = to_cxl_port(dev);

For CXL

Acked-by: Ira Weiny <ira.weiny@intel.com>