From: kernel test robot <lkp@intel.com>
To: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-usb@vger.kernel.org,
Wentong Wu <wentong.wu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v4 3/3] usb: misc: ljca: add firmware version sysfs attribute
Date: Tue, 12 Nov 2024 21:05:04 +0800 [thread overview]
Message-ID: <202411122028.tylKQSQx-lkp@intel.com> (raw)
In-Reply-To: <20241112075514.680712-3-stanislaw.gruszka@linux.intel.com>
Hi Stanislaw,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus westeri-thunderbolt/next linus/master v6.12-rc7 next-20241112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stanislaw-Gruszka/usb-misc-ljca-set-small-runtime-autosuspend-delay/20241112-155844
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20241112075514.680712-3-stanislaw.gruszka%40linux.intel.com
patch subject: [PATCH v4 3/3] usb: misc: ljca: add firmware version sysfs attribute
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241112/202411122028.tylKQSQx-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411122028.tylKQSQx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411122028.tylKQSQx-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/usb/misc/usb-ljca.c:169: warning: Function parameter or struct member 'fw_version' not described in 'ljca_adapter'
>> drivers/usb/misc/usb-ljca.c:169: warning: Function parameter or struct member 'fw_version_valid' not described in 'ljca_adapter'
vim +169 drivers/usb/misc/usb-ljca.c
acd6199f195d6de Wentong Wu 2023-10-09 114
acd6199f195d6de Wentong Wu 2023-10-09 115 /**
acd6199f195d6de Wentong Wu 2023-10-09 116 * struct ljca_adapter - represent a ljca adapter
acd6199f195d6de Wentong Wu 2023-10-09 117 *
acd6199f195d6de Wentong Wu 2023-10-09 118 * @intf: the usb interface for this ljca adapter
acd6199f195d6de Wentong Wu 2023-10-09 119 * @usb_dev: the usb device for this ljca adapter
acd6199f195d6de Wentong Wu 2023-10-09 120 * @dev: the specific device info of the usb interface
acd6199f195d6de Wentong Wu 2023-10-09 121 * @rx_pipe: bulk in pipe for receive data from firmware
acd6199f195d6de Wentong Wu 2023-10-09 122 * @tx_pipe: bulk out pipe for send data to firmware
acd6199f195d6de Wentong Wu 2023-10-09 123 * @rx_urb: urb used for the bulk in pipe
acd6199f195d6de Wentong Wu 2023-10-09 124 * @rx_buf: buffer used to receive command response and event
acd6199f195d6de Wentong Wu 2023-10-09 125 * @rx_len: length of rx buffer
acd6199f195d6de Wentong Wu 2023-10-09 126 * @ex_buf: external buffer to save command response
acd6199f195d6de Wentong Wu 2023-10-09 127 * @ex_buf_len: length of external buffer
acd6199f195d6de Wentong Wu 2023-10-09 128 * @actual_length: actual length of data copied to external buffer
acd6199f195d6de Wentong Wu 2023-10-09 129 * @tx_buf: buffer used to download command to firmware
acd6199f195d6de Wentong Wu 2023-10-09 130 * @tx_buf_len: length of tx buffer
acd6199f195d6de Wentong Wu 2023-10-09 131 * @lock: spinlock to protect tx_buf and ex_buf
acd6199f195d6de Wentong Wu 2023-10-09 132 * @cmd_completion: completion object as the command receives ack
acd6199f195d6de Wentong Wu 2023-10-09 133 * @mutex: mutex to avoid command download concurrently
acd6199f195d6de Wentong Wu 2023-10-09 134 * @client_list: client device list
acd6199f195d6de Wentong Wu 2023-10-09 135 * @disconnect: usb disconnect ongoing or not
acd6199f195d6de Wentong Wu 2023-10-09 136 * @reset_id: used to reset firmware
acd6199f195d6de Wentong Wu 2023-10-09 137 */
acd6199f195d6de Wentong Wu 2023-10-09 138 struct ljca_adapter {
acd6199f195d6de Wentong Wu 2023-10-09 139 struct usb_interface *intf;
acd6199f195d6de Wentong Wu 2023-10-09 140 struct usb_device *usb_dev;
acd6199f195d6de Wentong Wu 2023-10-09 141 struct device *dev;
acd6199f195d6de Wentong Wu 2023-10-09 142
acd6199f195d6de Wentong Wu 2023-10-09 143 unsigned int rx_pipe;
acd6199f195d6de Wentong Wu 2023-10-09 144 unsigned int tx_pipe;
acd6199f195d6de Wentong Wu 2023-10-09 145
acd6199f195d6de Wentong Wu 2023-10-09 146 struct urb *rx_urb;
acd6199f195d6de Wentong Wu 2023-10-09 147 void *rx_buf;
acd6199f195d6de Wentong Wu 2023-10-09 148 unsigned int rx_len;
acd6199f195d6de Wentong Wu 2023-10-09 149
acd6199f195d6de Wentong Wu 2023-10-09 150 u8 *ex_buf;
acd6199f195d6de Wentong Wu 2023-10-09 151 u8 ex_buf_len;
acd6199f195d6de Wentong Wu 2023-10-09 152 u8 actual_length;
acd6199f195d6de Wentong Wu 2023-10-09 153
acd6199f195d6de Wentong Wu 2023-10-09 154 void *tx_buf;
acd6199f195d6de Wentong Wu 2023-10-09 155 u8 tx_buf_len;
acd6199f195d6de Wentong Wu 2023-10-09 156
acd6199f195d6de Wentong Wu 2023-10-09 157 spinlock_t lock;
acd6199f195d6de Wentong Wu 2023-10-09 158
acd6199f195d6de Wentong Wu 2023-10-09 159 struct completion cmd_completion;
acd6199f195d6de Wentong Wu 2023-10-09 160 struct mutex mutex;
acd6199f195d6de Wentong Wu 2023-10-09 161
acd6199f195d6de Wentong Wu 2023-10-09 162 struct list_head client_list;
1368856f90435bb Stanislaw Gruszka 2024-11-12 163 struct ljca_fw_version fw_version;
acd6199f195d6de Wentong Wu 2023-10-09 164
acd6199f195d6de Wentong Wu 2023-10-09 165 bool disconnect;
1368856f90435bb Stanislaw Gruszka 2024-11-12 166 bool fw_version_valid;
acd6199f195d6de Wentong Wu 2023-10-09 167
acd6199f195d6de Wentong Wu 2023-10-09 168 u32 reset_id;
acd6199f195d6de Wentong Wu 2023-10-09 @169 };
acd6199f195d6de Wentong Wu 2023-10-09 170
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-12 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 7:55 [PATCH v4 1/3] usb: misc: ljca: move usb_autopm_put_interface() after wait for response Stanislaw Gruszka
2024-11-12 7:55 ` [PATCH v4 2/3] usb: misc: ljca: set small runtime autosuspend delay Stanislaw Gruszka
2024-11-12 7:55 ` [PATCH v4 3/3] usb: misc: ljca: add firmware version sysfs attribute Stanislaw Gruszka
2024-11-12 8:06 ` Greg Kroah-Hartman
2024-11-12 13:05 ` kernel test robot [this message]
2024-11-12 10:13 ` [PATCH v4 1/3] usb: misc: ljca: move usb_autopm_put_interface() after wait for response Hans de Goede
2024-11-12 10:33 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411122028.tylKQSQx-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox