From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Miao Zhu <Miao.Zhu@synopsys.com>
Cc: "heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"andre.draszik@linaro.org" <andre.draszik@linaro.org>,
"rdbabiera@google.com" <rdbabiera@google.com>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
"u.kleine-koenig@baylibre.com" <u.kleine-koenig@baylibre.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"emanuele.ghidoli@toradex.com" <emanuele.ghidoli@toradex.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jianheng Zhang <Jianheng.Zhang@synopsys.com>
Subject: Re: [PATCH V2 1/2] usb: typec: tcpm: tcpci: Make the driver be compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017]
Date: Tue, 3 Dec 2024 08:40:47 +0100 [thread overview]
Message-ID: <2024120332-flashcard-walnut-e57a@gregkh> (raw)
In-Reply-To: <LV2PR12MB5799131A376B5861CF1035D8BD362@LV2PR12MB5799.namprd12.prod.outlook.com>
On Tue, Dec 03, 2024 at 01:08:39AM +0000, Miao Zhu wrote:
> The tcpci driver doesn't fully follow the TCPCI spec even if
> it mentions this spec in its comments.
> - Add two flags into tcpci_data:
> RX_BUF_BYTE_x_hidden
> conn_present_capable
> - Following flags in tcpci_data are read from device tree in tcpci_probe.
> TX_BUF_BYTE_x_hidden
> RX_BUF_BYTE_x_hidden
> auto_discharge_disconnect
> vbus_vsafe0v
> The change makes the driver be compatible with the TCPCI spec and
> therefore won't impact existing HW.
>
> Signed-off-by: Miao Zhu Miao.Zhu@synopsys.com<mailto:Miao.Zhu@synopsys.com>
> ---
> V1 -> V2: Cleaned up typo and addressed review comments
HTML patches obviously can't be applied :(
next parent reply other threads:[~2024-12-03 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <LV2PR12MB5799131A376B5861CF1035D8BD362@LV2PR12MB5799.namprd12.prod.outlook.com>
2024-12-03 7:40 ` gregkh [this message]
2024-12-02 5:43 [PATCH] usb: typec: tcpm: tcpci: Make the driver be compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017] Xu Yang
2024-12-18 1:07 ` [PATCH v2 0/2] usb: typec: tcpci: Make the driver be compatible with TCPCI Spec Miao.Zhu
2024-12-18 1:07 ` [PATCH v2 1/2] usb: typec: tcpm: tcpci: Make the driver be compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017] Miao.Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024120332-flashcard-walnut-e57a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Jianheng.Zhang@synopsys.com \
--cc=Miao.Zhu@synopsys.com \
--cc=andre.draszik@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=rdbabiera@google.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).