[PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY

public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property
@ 2024-12-09 10:41 Xu Yang
  2024-12-09 10:46 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Xu Yang @ 2024-12-09 10:41 UTC (permalink / raw)
  To: mathias.nyman, gregkh, Frank.Li; +Cc: linux-usb, imx, jun.li

The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
software node property. This will set skip_phy_initialization if software
node also has XHCI_SKIP_PHY_INIT property.

Fixes: a6cd2b3fa894 ("usb: host: xhci-plat: Parse xhci-missing_cas_quirk and apply quirk")
Cc: stable@vger.kernel.org
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v2:
 - fix indentation
 - add fix tag and stable list
---
 drivers/usb/host/xhci-plat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index e6c9006bd568..77853b86794a 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
 
 	hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
 
-	if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
+	if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
+		(xhci->quirks & XHCI_SKIP_PHY_INIT))
 		hcd->skip_phy_initialization = 1;
 
 	if (priv && (priv->quirks & XHCI_SG_TRB_CACHE_SIZE_QUIRK))
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property
  2024-12-09 10:41 [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property Xu Yang
@ 2024-12-09 10:46 ` Greg KH
  2024-12-09 11:10   ` Xu Yang
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2024-12-09 10:46 UTC (permalink / raw)
  To: Xu Yang; +Cc: mathias.nyman, Frank.Li, linux-usb, imx, jun.li

On Mon, Dec 09, 2024 at 06:41:49PM +0800, Xu Yang wrote:
> The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
> software node property. This will set skip_phy_initialization if software
> node also has XHCI_SKIP_PHY_INIT property.
> 
> Fixes: a6cd2b3fa894 ("usb: host: xhci-plat: Parse xhci-missing_cas_quirk and apply quirk")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> 
> ---
> Changes in v2:
>  - fix indentation
>  - add fix tag and stable list
> ---
>  drivers/usb/host/xhci-plat.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index e6c9006bd568..77853b86794a 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
>  
>  	hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
>  
> -	if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
> +	if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
> +		(xhci->quirks & XHCI_SKIP_PHY_INIT))

Doesn't checkpatch.pl complain about this?  This is still not correct,
please follow the proper indentation rules here.  If you have questions
about this, please ask your coworkers who understand the style
requirements for Linux.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property
  2024-12-09 10:46 ` Greg KH
@ 2024-12-09 11:10   ` Xu Yang
  2024-12-09 16:41     ` Frank Li
  0 siblings, 1 reply; 5+ messages in thread
From: Xu Yang @ 2024-12-09 11:10 UTC (permalink / raw)
  To: Greg KH; +Cc: mathias.nyman, Frank.Li, linux-usb, imx, jun.li

On Mon, Dec 09, 2024 at 11:46:59AM +0100, Greg KH wrote:
> On Mon, Dec 09, 2024 at 06:41:49PM +0800, Xu Yang wrote:
> > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
> > software node property. This will set skip_phy_initialization if software
> > node also has XHCI_SKIP_PHY_INIT property.
> > 
> > Fixes: a6cd2b3fa894 ("usb: host: xhci-plat: Parse xhci-missing_cas_quirk and apply quirk")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > 
> > ---
> > Changes in v2:
> >  - fix indentation
> >  - add fix tag and stable list
> > ---
> >  drivers/usb/host/xhci-plat.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index e6c9006bd568..77853b86794a 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
> >  
> >  	hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
> >  
> > -	if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
> > +	if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
> > +		(xhci->quirks & XHCI_SKIP_PHY_INIT))
> 
> Doesn't checkpatch.pl complain about this?  This is still not correct,
> please follow the proper indentation rules here.  If you have questions
> about this, please ask your coworkers who understand the style
> requirements for Linux.

Sorry for wasting your time. It's a mistake. I made the change but it's not included finally.
BTW, checkpatch.pl doesn't complain the format. Not sure why.

Thanks,
Xu Yang

> 
> thanks,
> 
> greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property
  2024-12-09 11:10   ` Xu Yang
@ 2024-12-09 16:41     ` Frank Li
  2024-12-10  2:47       ` Xu Yang
  0 siblings, 1 reply; 5+ messages in thread
From: Frank Li @ 2024-12-09 16:41 UTC (permalink / raw)
  To: Xu Yang; +Cc: Greg KH, mathias.nyman, linux-usb, imx, jun.li

On Mon, Dec 09, 2024 at 07:10:14PM +0800, Xu Yang wrote:
> On Mon, Dec 09, 2024 at 11:46:59AM +0100, Greg KH wrote:
> > On Mon, Dec 09, 2024 at 06:41:49PM +0800, Xu Yang wrote:
> > > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
> > > software node property. This will set skip_phy_initialization if software
> > > node also has XHCI_SKIP_PHY_INIT property.
> > >
> > > Fixes: a6cd2b3fa894 ("usb: host: xhci-plat: Parse xhci-missing_cas_quirk and apply quirk")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v2:
> > >  - fix indentation
> > >  - add fix tag and stable list
> > > ---
> > >  drivers/usb/host/xhci-plat.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > > index e6c9006bd568..77853b86794a 100644
> > > --- a/drivers/usb/host/xhci-plat.c
> > > +++ b/drivers/usb/host/xhci-plat.c
> > > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
> > >
> > >  	hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
> > >
> > > -	if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
> > > +	if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
> > > +		(xhci->quirks & XHCI_SKIP_PHY_INIT))
> >
> > Doesn't checkpatch.pl complain about this?  This is still not correct,
> > please follow the proper indentation rules here.  If you have questions
> > about this, please ask your coworkers who understand the style
> > requirements for Linux.
>
> Sorry for wasting your time. It's a mistake. I made the change but it's not included finally.
> BTW, checkpatch.pl doesn't complain the format. Not sure why.

try --strict option.

Frank

>
> Thanks,
> Xu Yang
>
> >
> > thanks,
> >
> > greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property
  2024-12-09 16:41     ` Frank Li
@ 2024-12-10  2:47       ` Xu Yang
  0 siblings, 0 replies; 5+ messages in thread
From: Xu Yang @ 2024-12-10  2:47 UTC (permalink / raw)
  To: Frank Li; +Cc: Greg KH, mathias.nyman, linux-usb, imx, jun.li

On Mon, Dec 09, 2024 at 11:41:11AM -0500, Frank Li wrote:
> On Mon, Dec 09, 2024 at 07:10:14PM +0800, Xu Yang wrote:
> > On Mon, Dec 09, 2024 at 11:46:59AM +0100, Greg KH wrote:
> > > On Mon, Dec 09, 2024 at 06:41:49PM +0800, Xu Yang wrote:
> > > > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
> > > > software node property. This will set skip_phy_initialization if software
> > > > node also has XHCI_SKIP_PHY_INIT property.
> > > >
> > > > Fixes: a6cd2b3fa894 ("usb: host: xhci-plat: Parse xhci-missing_cas_quirk and apply quirk")
> > > > Cc: stable@vger.kernel.org
> > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > >
> > > > ---
> > > > Changes in v2:
> > > >  - fix indentation
> > > >  - add fix tag and stable list
> > > > ---
> > > >  drivers/usb/host/xhci-plat.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > > > index e6c9006bd568..77853b86794a 100644
> > > > --- a/drivers/usb/host/xhci-plat.c
> > > > +++ b/drivers/usb/host/xhci-plat.c
> > > > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
> > > >
> > > >  	hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
> > > >
> > > > -	if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
> > > > +	if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
> > > > +		(xhci->quirks & XHCI_SKIP_PHY_INIT))
> > >
> > > Doesn't checkpatch.pl complain about this?  This is still not correct,
> > > please follow the proper indentation rules here.  If you have questions
> > > about this, please ask your coworkers who understand the style
> > > requirements for Linux.
> >
> > Sorry for wasting your time. It's a mistake. I made the change but it's not included finally.
> > BTW, checkpatch.pl doesn't complain the format. Not sure why.
> 
> try --strict option.

It works.
Thank you Frank!


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-12-10  2:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-09 10:41 [PATCH v2] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property Xu Yang
2024-12-09 10:46 ` Greg KH
2024-12-09 11:10   ` Xu Yang
2024-12-09 16:41     ` Frank Li
2024-12-10  2:47       ` Xu Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox