public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ingo Rohloff <ingo.rohloff@lauterbach.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: configfs: Ignore trailing LF for user strings to cdev
Date: Thu, 12 Dec 2024 12:32:25 +0100	[thread overview]
Message-ID: <2024121213-alibi-jury-2ba4@gregkh> (raw)
In-Reply-To: <20241212111004.7901-1-ingo.rohloff@lauterbach.com>

On Thu, Dec 12, 2024 at 12:10:04PM +0100, Ingo Rohloff wrote:
> Since commit c033563220e0f7a8
> ("usb: gadget: configfs: Attach arbitrary strings to cdev")
> a user can provide extra string descriptors to a USB gadget via configfs.
> 
> For "manufacturer", "product", "serialnumber", setting the string via
> configfs ignores a trailing LF.
> 
> For the arbitrary strings the LF was not ignored.
> 
> This patch ignores a trailing LF to make this consistent with the existing
> behavior for "manufacturer", ...  string descriptors.
> 
> Signed-off-by: Ingo Rohloff <ingo.rohloff@lauterbach.com>
> ---
>  drivers/usb/gadget/configfs.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Shouldn't this get a Fixes: tag and cc: stable?

thanks,

greg k-h

      reply	other threads:[~2024-12-12 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 11:10 [PATCH] usb: gadget: configfs: Ignore trailing LF for user strings to cdev Ingo Rohloff
2024-12-12 11:32 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024121213-alibi-jury-2ba4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ingo.rohloff@lauterbach.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox