linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Aaron Rainbolt <arainbolt@kfocus.org>
Cc: YehezkelShB@gmail.com, michael.jamet@intel.com,
	andreas.noever@gmail.com, linux-usb@vger.kernel.org,
	mmikowski@kfocus.org, linux-kernel@vger.kernel.org,
	Gil Fine <gil.fine@linux.intel.com>
Subject: Re: USB-C DisplayPort display failing to stay active with Intel Barlow Ridge USB4 controller, power-management related issue?
Date: Fri, 13 Dec 2024 14:03:29 +0200	[thread overview]
Message-ID: <20241213120329.GA2788819@black.fi.intel.com> (raw)
In-Reply-To: <20241212161257.4110bdff@kf-ir16>

Hi Aaron,

On Thu, Dec 12, 2024 at 04:12:57PM -0600, Aaron Rainbolt wrote:
> On Fri, 15 Nov 2024 15:20:22 +0200
> Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> 
> > Hi,
> > 
> > On Thu, Nov 14, 2024 at 10:41:25AM -0600, Aaron Rainbolt wrote:
> > > This is production hardware (specifically Clevo's X370SNW1-G and
> > > X370SNV1-G laptops), available for purchase from Sager, XOTICPC,
> > > Schenker, likely many other resellers, and our own website
> > > at https://kfocus.org/spec/spec-m2.html (with a tool that allows users
> > > to work around the bug). The firmware is baked into the hardware
> > > provided to us by our ODM, and for the sake of stability we do not
> > > modify any firmware on the machines with the exception of applying
> > > BIOS updates provided to us directly by the ODM. They appear to get
> > > their firmware directly from Clevo.  
> > 
> > Okay thanks.
> > 
> > > We have requested an updated BIOS from the ODM. If one is
> > > available, we will upgrade and run the tests again.  
> > 
> > Yes, I hope you can get the firmwares. The one you have now is not
> > "production quality" firmare so you should not really have that there
> > in the first place and Clevo should definitely provide you an
> > upgrade. Note this is separate from the BIOS. But your BIOS has issue
> > too regarding the USB4 power contract that is required by Microsoft
> > so I would expect that you should get that one upgraded too.
> > 
> > The patch I shared earlier should deal with all the other cases except
> > that weird one where we do not seem to get unplugs (and the resource
> > is available) which is not how the firmware is expected to work. I was
> > planning to submit it upstream after some more validation on our end,
> > probably afer v6.13-rc1 is released. I'll CC you.
> > 
> > If/when you get the new firmare I would definitely appreciate if your
> > folks could give it a try.
> 
> Hi Mika:
> 
> Just to catch you up: 
> We find the most recent patch from this thread to be a good improvement.
> 
> We tested it on our hardware with USB-C attached displays. In
> particular, it allows us to enable displays that do not time out while
> using with Thunderbolt. Without the patch, enabling the Thunderbolt
> kernel module would disable all attached USB-C displays in 15 seconds.
> 
> The patch does not resolve the hot plugging issue on our hardware, but
> we have a work-around for that (lspci -k or reloading the thunderbolt
> module). We have not been able to acquire new firmware yet, so this is
> likely the issue.
> 
> The test results are attached if you are interested.

Thanks for testing!

You probably noticed, I sent out a formal patch here:

https://lore.kernel.org/linux-usb/20241211103529.2302706-1-mika.westerberg@linux.intel.com/

You are Cc'd. I wonder if I can add your Tested-by tag to it?

  reply	other threads:[~2024-12-13 12:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10  3:01 USB-C DisplayPort display failing to stay active with Intel Barlow Ridge USB4 controller, power-management related issue? Aaron Rainbolt
2024-10-10  4:49 ` Mika Westerberg
2024-10-11  4:26   ` Aaron Rainbolt
2024-10-11 16:38     ` Mika Westerberg
2024-10-11 18:02       ` Aaron Rainbolt
2024-10-11 23:37       ` Aaron Rainbolt
2024-10-23  6:27         ` Mika Westerberg
2024-10-23  7:39           ` Mika Westerberg
2024-10-23 22:44             ` Aaron Rainbolt
2024-10-24 15:43               ` Mika Westerberg
2024-10-31 14:55                 ` Aaron Rainbolt
2024-11-01  7:21                   ` Mika Westerberg
2024-11-01 23:13                     ` Aaron Rainbolt
2024-11-04  6:01                       ` Mika Westerberg
2024-11-05 20:16                         ` Aaron Rainbolt
2024-11-06  6:06                           ` Mika Westerberg
2024-11-06 17:01                             ` Aaron Rainbolt
2024-11-07  9:45                               ` Mika Westerberg
2024-11-11  8:22                                 ` Mika Westerberg
2024-11-12 21:44                                   ` Aaron Rainbolt
2024-11-14 11:51                                     ` Mika Westerberg
2024-11-14 16:41                                       ` Aaron Rainbolt
2024-11-15 13:20                                         ` Mika Westerberg
2024-12-12 22:12                                           ` Aaron Rainbolt
2024-12-13 12:03                                             ` Mika Westerberg [this message]
2025-01-24 23:05                                           ` Aaron Rainbolt
2025-01-26  5:53                                             ` Mika Westerberg
2025-01-26 16:12                                               ` Gil Fine
2025-01-28  8:29                                                 ` Gil Fine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241213120329.GA2788819@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=arainbolt@kfocus.org \
    --cc=gil.fine@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mmikowski@kfocus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).