public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Niklas Neronin <niklas.neronin@linux.intel.com>
To: WeitaoWang-oc@zhaoxin.com, mathias.nyman@linux.intel.com
Cc: linux-usb@vger.kernel.org,
	Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: [PATCH 0/2] Possible xHCI driver fix for ZHAOXIN hosts
Date: Tue, 17 Dec 2024 13:29:15 +0200	[thread overview]
Message-ID: <20241217112917.623898-1-niklas.neronin@linux.intel.com> (raw)

Hi Weitao Wang,

You fixed an issue in the Linux xHCI driver which concerned TRB prefetch on
ZHAOXIN hosts [1]. The fix was to allocate two pages for a segment instead
of one, on some ZHAOXIN hosts.

I recently noticed that the xHCI driver always sets the page size to 4096
bytes, regardless of whether a 4096-page size is supported. This may be the
root issue that your patch fixed.

I do not have access to a ZHAOXIN system, so could you please test the two
patches? The first patch sets the xHCI page size to the size supported by
the xHCI controller, and the second patch reverts your fix [1].

The patches are built on top of Linux 6.12.

[1], commit 2a865a652299 ("xhci: Fix TRB prefetch issue of ZHAOXIN hosts")

Niklas Neronin (2):
  usb: xhci: set page size to the xHCI-supported size
  Revert "xhci: Fix TRB prefetch issue of ZHAOXIN hosts"

 drivers/usb/host/xhci-mem.c | 36 ++++++++++++++----------------------
 drivers/usb/host/xhci-pci.c |  7 +------
 drivers/usb/host/xhci.h     | 10 +++++-----
 3 files changed, 20 insertions(+), 33 deletions(-)

-- 
2.45.2


             reply	other threads:[~2024-12-17 11:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 11:29 Niklas Neronin [this message]
2024-12-17 11:29 ` [PATCH 1/2] usb: xhci: set page size to the xHCI-supported size Niklas Neronin
2024-12-17 11:29 ` [PATCH 2/2] Revert "xhci: Fix TRB prefetch issue of ZHAOXIN hosts" Niklas Neronin
2024-12-18  6:55   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241217112917.623898-1-niklas.neronin@linux.intel.com \
    --to=niklas.neronin@linux.intel.com \
    --cc=WeitaoWang-oc@zhaoxin.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox