linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mingwei Zheng <zmw12306@gmail.com>
Cc: u.kleine-koenig@baylibre.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: Re: [PATCH] usb: gadget: m66592-udc: Add check for clk_enable()
Date: Thu, 26 Dec 2024 09:19:20 +0100	[thread overview]
Message-ID: <2024122634--ec5b@gregkh> (raw)
In-Reply-To: <20241224202217.114436-1-zmw12306@gmail.com>

On Tue, Dec 24, 2024 at 03:22:17PM -0500, Mingwei Zheng wrote:
> The APP-Miner reported the missing check.

What does this mean?  Please explain it better as the documentation
states you must do when using random research tools.

> Add check for the return value of clk_enable() to catch the potential
> error.
> 
> Fixes: b4822e2317e8 ("usb: gadget: m66592-udc: Convert to use module_platform_driver()")

Why is this only a Fixes tag and not also a cc: stable?  And how did you
test it?

thanks,

greg k-h

  reply	other threads:[~2024-12-26  8:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-24 20:22 [PATCH] usb: gadget: m66592-udc: Add check for clk_enable() Mingwei Zheng
2024-12-26  8:19 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-12-15 20:53 Mingwei Zheng
2024-12-16  7:55 ` Greg KH
2024-12-18  3:06   ` Mingwei Zheng
2024-12-23 17:30     ` Greg KH
2024-12-26  1:35       ` Mingwei Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024122634--ec5b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jiashengjiangcool@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=zmw12306@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).