From: Greg KH <gregkh@linuxfoundation.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: ukaszb@chromium.org, abhishekpandit@chromium.org,
bleung@chromium.org, chrome-platform@lists.linux.dev,
dmitry.baryshkov@linaro.org, heikki.krogerus@linux.intel.com,
jthies@google.com, linux-usb@vger.kernel.org,
pholla@chromium.org, tzungbi@kernel.org
Subject: Re: [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands
Date: Sat, 4 Jan 2025 09:12:34 +0100 [thread overview]
Message-ID: <2025010438-canopener-renounce-4a28@gregkh> (raw)
In-Reply-To: <20250103233407.4001046-1-gwendal@chromium.org>
On Fri, Jan 03, 2025 at 03:34:07PM -0800, Gwendal Grignou wrote:
> Add this patch to "platform/chrome: Update ChromeOS EC header for UCSI"
I do not understand this changelog text, sorry. How can you "add"
something to an existing change?
> to add the new commands form cros_ec_commands.h in the tracer so that
> they are nicely decoded. Enable the tracer with:
> cd /sys/kernel/debug/tracing
> echo 1 > events/cros_ec/enable
> echo 1 > tracing_on
> cat trace_pipe
We don't need to document how to enable a tracepoint here in the
changelog, right? That's going to get lost and why is this new one
somehow special?
confused,
greg k-h
next prev parent reply other threads:[~2025-01-04 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 13:10 [PATCH v12 0/2] usb: typec: Implement UCSI driver for ChromeOS Łukasz Bartosik
2024-12-31 13:10 ` [PATCH v12 1/2] platform/chrome: Update ChromeOS EC header for UCSI Łukasz Bartosik
2025-01-03 23:34 ` [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands Gwendal Grignou
2025-01-04 7:55 ` kernel test robot
2025-01-04 8:12 ` Greg KH [this message]
2025-01-06 18:43 ` Gwendal Grignou
2025-01-07 10:33 ` Greg KH
2025-01-04 16:27 ` kernel test robot
2024-12-31 13:10 ` [PATCH v12 2/2] usb: typec: ucsi: Implement ChromeOS UCSI driver Łukasz Bartosik
2025-01-07 10:28 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025010438-canopener-renounce-4a28@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dmitry.baryshkov@linaro.org \
--cc=gwendal@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=pholla@chromium.org \
--cc=tzungbi@kernel.org \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox