* [PATCH] usb: dwc3: omap: Fix devm_regulator_get_optional() error handling
@ 2025-01-09 17:07 Rob Herring (Arm)
2025-01-10 2:37 ` Thinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-01-09 17:07 UTC (permalink / raw)
To: Thinh Nguyen, Greg Kroah-Hartman, Liam Girdwood, Mark Brown
Cc: linux-usb, linux-omap, linux-kernel
Commit 533561a8aad5 ("usb: dwc3: omap: Use
devm_regulator_get_optional()") assumed NULL was returned, but
devm_regulator_get_optional() returns -ENODEV rather than NULL like
other *_get_optional() functions.
Fixes: 533561a8aad5 ("usb: dwc3: omap: Use devm_regulator_get_optional()")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/usb/dwc3/dwc3-omap.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 9b1d10ac33c1..fe74d11bb629 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -484,8 +484,11 @@ static int dwc3_omap_probe(struct platform_device *pdev)
return PTR_ERR(base);
vbus_reg = devm_regulator_get_optional(dev, "vbus");
- if (IS_ERR(vbus_reg))
- return dev_err_probe(dev, PTR_ERR(vbus_reg), "vbus init failed\n");
+ if (IS_ERR(vbus_reg)) {
+ if (PTR_ERR(vbus_reg) != -ENODEV)
+ return dev_err_probe(dev, PTR_ERR(vbus_reg), "vbus init failed\n");
+ vbus_reg = NULL;
+ }
omap->dev = dev;
omap->irq = irq;
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: dwc3: omap: Fix devm_regulator_get_optional() error handling
2025-01-09 17:07 [PATCH] usb: dwc3: omap: Fix devm_regulator_get_optional() error handling Rob Herring (Arm)
@ 2025-01-10 2:37 ` Thinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Thinh Nguyen @ 2025-01-10 2:37 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Thinh Nguyen, Greg Kroah-Hartman, Liam Girdwood, Mark Brown,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
On Thu, Jan 09, 2025, Rob Herring (Arm) wrote:
> Commit 533561a8aad5 ("usb: dwc3: omap: Use
> devm_regulator_get_optional()") assumed NULL was returned, but
> devm_regulator_get_optional() returns -ENODEV rather than NULL like
> other *_get_optional() functions.
>
> Fixes: 533561a8aad5 ("usb: dwc3: omap: Use devm_regulator_get_optional()")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> drivers/usb/dwc3/dwc3-omap.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index 9b1d10ac33c1..fe74d11bb629 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -484,8 +484,11 @@ static int dwc3_omap_probe(struct platform_device *pdev)
> return PTR_ERR(base);
>
> vbus_reg = devm_regulator_get_optional(dev, "vbus");
> - if (IS_ERR(vbus_reg))
> - return dev_err_probe(dev, PTR_ERR(vbus_reg), "vbus init failed\n");
> + if (IS_ERR(vbus_reg)) {
> + if (PTR_ERR(vbus_reg) != -ENODEV)
> + return dev_err_probe(dev, PTR_ERR(vbus_reg), "vbus init failed\n");
> + vbus_reg = NULL;
> + }
>
> omap->dev = dev;
> omap->irq = irq;
> --
> 2.45.2
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-10 2:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 17:07 [PATCH] usb: dwc3: omap: Fix devm_regulator_get_optional() error handling Rob Herring (Arm)
2025-01-10 2:37 ` Thinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox