Re: [PATCH 2/2] usb: typec: cros-ec-ucsi: Mark cros_ucsi_ops static/const

Łukasz Bartosik
2025-01-10T13:47:53Z

On Thu, Jan 9, 2025 at 11:07 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This structure isn't used outside this file and can be marked const so
> that it gets moved to read-only memory.
>
> Cc: Pavan Holla <pholla@chromium.org>
> Cc: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Cc: Łukasz Bartosik <ukaszb@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Łukasz Bartosik <ukaszb@chromium.org>

> ---
> drivers/usb/typec/ucsi/cros_ec_ucsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> index 75646a8d55be..c605c8616726 100644
> --- a/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> +++ b/drivers/usb/typec/ucsi/cros_ec_ucsi.c
> @@ -133,7 +133,7 @@ static int cros_ucsi_sync_control(struct ucsi *ucsi, u64 cmd)
> return ret;
> }
>
> -struct ucsi_operations cros_ucsi_ops = {
> +static const struct ucsi_operations cros_ucsi_ops = {
> .read_version = cros_ucsi_read_version,
> .read_cci = cros_ucsi_read_cci,
> .read_message_in = cros_ucsi_read_message_in,