From: "Michał Pecio" <michal.pecio@gmail.com>
To: Niklas Neronin <niklas.neronin@linux.intel.com>
Cc: mathias.nyman@linux.intel.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/2] usb: xhci: correct debug message page size calculation
Date: Mon, 13 Jan 2025 17:00:43 +0100 [thread overview]
Message-ID: <20250113170043.25d689a5@foxbook> (raw)
In-Reply-To: <20250113143037.2131346-2-niklas.neronin@linux.intel.com>
On Mon, 13 Jan 2025 16:30:36 +0200, Niklas Neronin wrote:
> Fix this by subtracting one from the result of ffs(). Note that since
> variable 'i' is unsigned, subtracting one from zero will result in the
> maximum unsigned integer value. Consequently, the condition 'if (i <
> 16)' will still function correctly.
Is it unsigned? I see a simple 'int' here, so this wouldn't work.
Michal
next prev parent reply other threads:[~2025-01-13 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 14:30 [PATCH v2 0/2] usb: xhci: page size improvements Niklas Neronin
2025-01-13 14:30 ` [PATCH v2 1/2] usb: xhci: correct debug message page size calculation Niklas Neronin
2025-01-13 16:00 ` Michał Pecio [this message]
2025-01-14 8:31 ` Neronin, Niklas
2025-01-13 14:30 ` [PATCH v2 2/2] usb: xhci: set page size to the xHCI-supported size Niklas Neronin
2025-01-14 9:34 ` Michał Pecio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113170043.25d689a5@foxbook \
--to=michal.pecio@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=niklas.neronin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).