public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Forest <forestix@nom.one>
Cc: linux-kernel@vger.kernel.org,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	linux-usb@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH] USB: Add LPM quirk for sony xperia xz1 compact
Date: Thu, 16 Jan 2025 11:10:50 +0100	[thread overview]
Message-ID: <2025011608-shady-recite-62f6@gregkh> (raw)
In-Reply-To: <10kgojpeckdq0pb4d95k1prma49du5itre@sonic.net>

On Wed, Jan 15, 2025 at 04:18:22PM -0800, Forest wrote:
> Since USB 2 LPM was enabled for this device by 63a1f8454962
> ("xhci: stored cached port capability values in one place"),
> the fastboot tool for communicating with Android bootloaders no longer
> works reliably. Various fastboot commands are affected, including the
> following, which usually reproduces the problem within two tries:
> 
>   fastboot getvar kernel
> 
> A typical error message when that command fails:
> 
>   getvar:kernel  FAILED (remote: 'GetVar Variable Not found')
> 
> Adding the quirk resolves the regression. No drawbacks are expected,
> since the device uses different USB product IDs outside of fastboot
> mode, and since fastboot commands worked until LPM was enabled by the
> aforementioned commit.
> 
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/hk8umj9lv4l4qguftdq1luqtdrpa1gks5l@sonic.net
> Signed-off-by: Forest <forestix@nom.one>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)

Always use scripts/get_maintainer.pl to get the correct people to cc:

Also, we need a "real" name here, sorry.

thanks,

greg k-h

  reply	other threads:[~2025-01-16 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  0:18 [PATCH] USB: Add LPM quirk for sony xperia xz1 compact Forest
2025-01-16 10:10 ` Greg KH [this message]
2025-01-16 20:01   ` Forest
2025-01-17  6:10     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025011608-shady-recite-62f6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=forestix@nom.one \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox