From: Guan-Yu Lin <guanyulin@google.com>
To: gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
mathias.nyman@intel.com, stern@rowland.harvard.edu,
perex@perex.cz, tiwai@suse.com, sumit.garg@linaro.org,
kekrby@gmail.com, oneukum@suse.com, ricardo@marliere.net,
lijiayi@kylinos.cn, quic_jjohnson@quicinc.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, Guan-Yu Lin <guanyulin@google.com>
Subject: [PATCH v9 4/5] xhci: sideband: add api to trace sideband usage
Date: Fri, 17 Jan 2025 14:48:04 +0000 [thread overview]
Message-ID: <20250117145145.3093352-5-guanyulin@google.com> (raw)
In-Reply-To: <20250117145145.3093352-1-guanyulin@google.com>
The existing sideband driver only registers sidebands without tracking
their active usage. To address this, new apis are introduced to:
- mark sideband usage: record the sideband usage information in the USB
device driver.
- query sideband status: provide a means for other drivers to fetch
sideband activity information on a USB host controller.
Signed-off-by: Guan-Yu Lin <guanyulin@google.com>
---
drivers/usb/host/xhci-sideband.c | 82 +++++++++++++++++++++++++++++++
include/linux/usb/xhci-sideband.h | 6 +++
2 files changed, 88 insertions(+)
diff --git a/drivers/usb/host/xhci-sideband.c b/drivers/usb/host/xhci-sideband.c
index ffa6f1b825ff..d4931315dcf4 100644
--- a/drivers/usb/host/xhci-sideband.c
+++ b/drivers/usb/host/xhci-sideband.c
@@ -358,6 +358,88 @@ xhci_sideband_interrupter_id(struct xhci_sideband *sb)
}
EXPORT_SYMBOL_GPL(xhci_sideband_interrupter_id);
+/**
+ * xhci_sideband_get - record a new active sideband instance
+ * @sb: sideband instance for this usb device
+ *
+ * An active sideband indicates that another entity is currently using the host
+ * controller. Inform the usb_device associated with this sideband instance via
+ * usb_offload_get(). This allows the corresponding drivers to dynamically
+ * adjust power management actions based on current sideband activities.
+ *
+ * Returns 0 on success, negative error otherwise.
+ */
+int xhci_sideband_get(struct xhci_sideband *sb)
+{
+ struct usb_device *udev;
+ struct usb_hcd *hcd;
+ int ret = 0;
+
+ if (!sb || !sb->xhci)
+ return -ENODEV;
+
+ hcd = xhci_to_hcd(sb->xhci);
+ udev = sb->vdev->udev;
+ device_lock(&udev->dev);
+ ret = usb_offload_get(udev);
+ device_unlock(&udev->dev);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(xhci_sideband_get);
+
+/**
+ * xhci_sideband_put - record a deactivated sideband instance
+ * @sb: sideband instance for this usb device
+ *
+ * The inverse operation of xhci_sideband_get, which informs the associated
+ * usb_device via usb_offload_put(). This allows the corresponding drivers to
+ * dynamically adjust power management actions based on sideband activities.
+ *
+ * Returns 0 on success, negative error otherwise.
+ */
+int xhci_sideband_put(struct xhci_sideband *sb)
+{
+ struct usb_device *udev;
+ struct usb_hcd *hcd;
+ int ret = 0;
+
+ if (!sb || !sb->xhci)
+ return -ENODEV;
+
+ hcd = xhci_to_hcd(sb->xhci);
+ udev = sb->vdev->udev;
+ device_lock(&udev->dev);
+ ret = usb_offload_put(udev);
+ device_unlock(&udev->dev);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(xhci_sideband_put);
+
+/**
+ * xhci_sideband_check - check the existence of active sidebands
+ * @hcd: the host controller driver associated with the target host controller
+ *
+ * Allow other drivers, such as usb controller driver, to check if there are
+ * any sideband activity on the host controller. This information could be used
+ * for power management or other forms of resource management.
+ *
+ * Returns true on any active sideband existence, false otherwise.
+ */
+bool xhci_sideband_check(struct usb_hcd *hcd)
+{
+ struct usb_device *udev = hcd->self.root_hub;
+ bool active;
+
+ device_lock(&udev->dev);
+ active = usb_offload_check(udev);
+ device_unlock(&udev->dev);
+
+ return active;
+}
+EXPORT_SYMBOL_GPL(xhci_sideband_check);
+
/**
* xhci_sideband_register - register a sideband for a usb device
* @intf: usb interface associated with the sideband device
diff --git a/include/linux/usb/xhci-sideband.h b/include/linux/usb/xhci-sideband.h
index 72aa17eb068d..6de1d9c161a1 100644
--- a/include/linux/usb/xhci-sideband.h
+++ b/include/linux/usb/xhci-sideband.h
@@ -11,6 +11,7 @@
#include <linux/scatterlist.h>
#include <linux/usb.h>
+#include <linux/usb/hcd.h>
#define EP_CTX_PER_DEV 31 /* FIXME defined twice, from xhci.h */
@@ -82,6 +83,11 @@ xhci_sideband_get_endpoint_buffer(struct xhci_sideband *sb,
struct usb_host_endpoint *host_ep);
struct sg_table *
xhci_sideband_get_event_buffer(struct xhci_sideband *sb);
+
+int xhci_sideband_get(struct xhci_sideband *sb);
+int xhci_sideband_put(struct xhci_sideband *sb);
+bool xhci_sideband_check(struct usb_hcd *hcd);
+
int
xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
bool ip_autoclear, u32 imod_interval, int intr_num);
--
2.48.0.rc2.279.g1de40edade-goog
next prev parent reply other threads:[~2025-01-17 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 14:48 [PATCH v9 0/5] Support system sleep with offloaded usb transfers Guan-Yu Lin
2025-01-17 14:48 ` [PATCH v9 1/5] usb: dwc3: separate dev_pm_ops for each pm_event Guan-Yu Lin
2025-01-17 14:48 ` [PATCH v9 2/5] usb: xhci-plat: " Guan-Yu Lin
2025-01-17 14:48 ` [PATCH v9 3/5] usb: add apis for offload usage tracking Guan-Yu Lin
2025-01-17 14:48 ` Guan-Yu Lin [this message]
2025-01-17 14:48 ` [PATCH v9 5/5] usb: host: enable USB offload during system sleep Guan-Yu Lin
2025-02-06 0:13 ` Michał Pecio
2025-02-07 11:00 ` Guan-Yu Lin
2025-01-17 15:55 ` [PATCH v9 0/5] Support system sleep with offloaded usb transfers Pierre-Louis Bossart
2025-01-22 16:05 ` Guan-Yu Lin
2025-01-28 15:11 ` Pierre-Louis Bossart
2025-02-03 2:57 ` Guan-Yu Lin
2025-02-03 23:57 ` Pierre-Louis Bossart
2025-02-07 10:54 ` Guan-Yu Lin
2025-02-07 17:28 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117145145.3093352-5-guanyulin@google.com \
--to=guanyulin@google.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=kekrby@gmail.com \
--cc=lijiayi@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=quic_jjohnson@quicinc.com \
--cc=ricardo@marliere.net \
--cc=stern@rowland.harvard.edu \
--cc=sumit.garg@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).