From: Qasim Ijaz <qasdev00@gmail.com>
To: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
gregkh@linuxfoundation.org, sergei.shtylyov@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot <syzbot+83976e47ec1ef91e66f1@syzkaller.appspotmail.com>
Subject: [PATCH v2] USB: usbip: fix null-ptr-deref in status_show_vhci()
Date: Wed, 22 Jan 2025 12:15:29 +0000 [thread overview]
Message-ID: <20250122121529.15421-1-qasdev00@gmail.com> (raw)
If usb_add_hcd() fails in vhci_hcd_probe() (i.e., a probe failure),
the error path calls usb_remove_hcd() and also sets
pdev->dev.driver_data to NULL.
Consequently, any subsequent call to platform_get_drvdata(pdev)
(which returns pdev->dev.driver_data) may yield NULL, causing a
crash if that pointer is dereferenced.
Fix this by adding a sanity check to ensure "hcd" is non-NULL
before proceeding with further operations.
Reported-by: syzbot <syzbot+83976e47ec1ef91e66f1@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=83976e47ec1ef91e66f1
Tested-by: syzbot <syzbot+83976e47ec1ef91e66f1@syzkaller.appspotmail.com>
Fixes: 03cd00d538a6 ("usbip: vhci-hcd: Set the vhci structure up to work")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
drivers/usb/usbip/vhci_sysfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/usbip/vhci_sysfs.c b/drivers/usb/usbip/vhci_sysfs.c
index d5865460e82d..d4a1aa6d06b2 100644
--- a/drivers/usb/usbip/vhci_sysfs.c
+++ b/drivers/usb/usbip/vhci_sysfs.c
@@ -76,6 +76,9 @@ static ssize_t status_show_vhci(int pdev_nr, char *out)
}
hcd = platform_get_drvdata(pdev);
+ if (!hcd)
+ return 0;
+
vhci_hcd = hcd_to_vhci_hcd(hcd);
vhci = vhci_hcd->vhci;
--
2.39.5
next reply other threads:[~2025-01-22 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 12:15 Qasim Ijaz [this message]
2025-01-22 12:30 ` [PATCH v2] USB: usbip: fix null-ptr-deref in status_show_vhci() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122121529.15421-1-qasdev00@gmail.com \
--to=qasdev00@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=shuah@kernel.org \
--cc=syzbot+83976e47ec1ef91e66f1@syzkaller.appspotmail.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).