Re: AW: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support

Johan Hovold
2025-02-11T14:25:14Z

On Mon, Feb 03, 2025 at 03:51:52PM +0000, Ulv Michel wrote:
> Hello Greg,
>
> > We need a full name, sorry.
> the full name is Ulv Michel.
>
> > And where is patch 1/2 of this series?

> Part 1 is this: https://lore.kernel.org/linux-usb/2025012501-pediatric-abide-b802@gregkh/T/#t

Looks like something went wrong with the threading when you submitted
this series.

You can resend the patches individually if you prefer since they go
through different trees anyway, but you should get your mail setup fixed
for future contributions anyway.

Try sending it to yourself first.

> > > .driver_info = RSVD(1) | RSVD(4) },
> > > + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */
>
> > You forgot a tab before the comment :(

> :( I removed the tab because the checkpatch.pl complained the length of the line being more than 100 columns...
> What would be you suggestion? Resubmit? Or keep it?

It's ok with lines longer than 100 columns here in these tables.

Please submit a v2 with your full name in From and in the SoB tags as
well.

One more comment below.

> -----Ursprüngliche Nachricht-----
> Von: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Gesendet: Montag, 3. Februar 2025 16:17
> An: Ulv Michel <ulv@on2.de>
> Cc: Johan Hovold <johan@kernel.org>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support
>
> On Sat, Jan 25, 2025 at 10:40:05AM +0100, U Michel wrote:
> > From: U M <ulv@on2.de>
>
> We need a full name, sorry.
>
> And where is patch 1/2 of this series?

> > Signed-off-by: U M <ulv@on2.de>
> > ---
> > drivers/usb/serial/option.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index 1e2ae0c6c41c..b166f1607b0e 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -2285,6 +2285,7 @@ static const struct usb_device_id option_ids[] = {
> > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */
> > { USB_DEVICE_INTERFACE_CLASS(0x1435, 0xd191, 0xff), /* Wistron Neweb D19Q1 */
> > .driver_info = RSVD(1) | RSVD(4) },
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) }, /* Wistron Neweb M18QW */

And try to keep the entries sorted by VID/PID when possible (e.g. within
this Wistron subsection).

> You forgot a tab before the comment :(

Johan