From: Greg KH <gregkh@linuxfoundation.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, zhanjun@uniontech.com,
guanwentao@uniontech.com, chenlinxuan@uniontech.com,
Xinwei Zhou <zhouxinwei@uniontech.com>,
Xu Rao <raoxu@uniontech.com>,
Yujing Ming <mingyujing@uniontech.com>
Subject: Re: [PATCH] usb-storage: Bypass certain SCSI commands on disks with "use_192_bytes_for_3f" attribute
Date: Thu, 6 Feb 2025 06:50:40 +0100 [thread overview]
Message-ID: <2025020649-say-maturing-c061@gregkh> (raw)
In-Reply-To: <AC1BB7F0327EFB9C+20250206054107.9085-1-wangyuli@uniontech.com>
On Thu, Feb 06, 2025 at 01:41:07PM +0800, WangYuli wrote:
> @@ -369,6 +370,13 @@ static int queuecommand_lck(struct scsi_cmnd *srb)
> return SCSI_MLQUEUE_HOST_BUSY;
> }
>
> + if (srb->cmnd[0] == MODE_SENSE && sdev->use_192_bytes_for_3f == 1 &&
> + srb->cmnd[2] == 0x3f && srb->cmnd[4] != 192) {
> + srb->result = DID_ABORT << 16;
> + done(srb);
> + return 0;
> + }
> +
Please always run scripts/checkpatch.pl on your changes before sending
them out so you don't get a grumpy maintainer asking why you didn't run
scripts/checkpatch.pl on your patch :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-06 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 5:41 [PATCH] usb-storage: Bypass certain SCSI commands on disks with "use_192_bytes_for_3f" attribute WangYuli
2025-02-06 5:50 ` Greg KH [this message]
2025-02-06 14:58 ` Alan Stern
2025-02-07 9:15 ` WangYuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025020649-say-maturing-c061@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chenlinxuan@uniontech.com \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingyujing@uniontech.com \
--cc=raoxu@uniontech.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
--cc=zhouxinwei@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox