From: Greg KH <gregkh@linuxfoundation.org>
To: Matt Lee <matt@oscium.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: max3421: Improve retransmit handling for NAK responses
Date: Mon, 10 Feb 2025 15:06:29 +0100 [thread overview]
Message-ID: <2025021006-engulf-dreary-d232@gregkh> (raw)
In-Reply-To: <CABrMTjempFXxCt4FhZPVUo=4h+o1hxoppoOmbfcbD-yGLt==Xg@mail.gmail.com>
On Mon, Feb 10, 2025 at 07:48:28AM -0600, Matt Lee wrote:
> This reverts a previously submitted patch where the slow retransmit was
> removed.
>
> The max3421 driver would immediately retry transmissions indefinitely upon
> receiving a NAK response, leading to potential stalls.
>
> This patch re-introduces a limit (`NAK_MAX_FAST_RETRANSMITS`) on how many
> times a request is retransmitted immediately. After reaching this limit,
> the driver falls back to a slower retransmit strategy using
> `max3421_slow_retransmit()`.
>
> This improves robustness when dealing with unresponsive USB devices.
>
> Signed-off-by: Matt Lee <matt@oscium.com>
> ---
> drivers/usb/host/max3421-hcd.c | 7 +++++++
> 1 file changed, 7 insertions(+)
I got 2 copies of this, is that intentional?
And patch 2/2 should be threaded with this one, did you use git
send-email to send these out?
thanks,
greg k-h
next parent reply other threads:[~2025-02-10 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABrMTjempFXxCt4FhZPVUo=4h+o1hxoppoOmbfcbD-yGLt==Xg@mail.gmail.com>
2025-02-10 14:06 ` Greg KH [this message]
2025-02-10 13:57 [PATCH 1/2] USB: max3421: Improve retransmit handling for NAK responses Matt Lee
2025-02-10 14:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021006-engulf-dreary-d232@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=matt@oscium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox