From: Greg KH <gregkh@linuxfoundation.org>
To: Matt Lee <matt@oscium.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] USB: max3421: Fix scheduling while atomic in max3421_remove()
Date: Mon, 10 Feb 2025 16:51:42 +0100 [thread overview]
Message-ID: <2025021031-pessimism-studied-99d3@gregkh> (raw)
In-Reply-To: <CABrMTjdJ6Xpwo2+oExb7i1jCuRJNb8tDJtov-xsnyiSoOxF-3w@mail.gmail.com>
On Mon, Feb 10, 2025 at 09:42:46AM -0600, Matt Lee wrote:
> The submitted patch fixes a crash we are experiencing on every shutdown.
> Perhaps the better solution is to remove the spin_lock_irqsave/restore?
Please don't top post.
Having a lock/unlock pair without anything in it can be used for
something (it's a gate primitive), but I don't think that it's being
used for that here.
> I tested removing the spin_lock completely and the crash issue was eliminated.
> Happy to update the patch if this is the preferred method.
Ideally fix the root issue in that this lock is needed to protect the
data here, so removing it doesn't actually fix the real problem, only
trade the crash for a race condition, right?
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-10 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABrMTje0ijdtcO31HmuSufxXFQO2Ay2Rh0_0Qc4FFC3zgqe-pA@mail.gmail.com>
2025-02-10 14:07 ` [PATCH 2/2] USB: max3421: Fix scheduling while atomic in max3421_remove() Greg KH
2025-02-10 15:42 ` Matt Lee
2025-02-10 15:51 ` Greg KH [this message]
2025-02-10 14:06 Matt Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021031-pessimism-studied-99d3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=matt@oscium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox