Re: [PATCH next 1/3] dt-bindings: usb: microchip,usb2514: add support for vdda

Conor Dooley
2025-02-11T16:45:42Z

[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]

On Tue, Feb 11, 2025 at 11:58:37AM +0100, Catalin Popescu wrote:
> Microchip hub USB2514 has one 3V3 digital power supply and one 3V3
> analog power supply. Add support for analog power supply vdda.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
> .../bindings/usb/microchip,usb2514.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index b14e6f37b298..743f7a22f13d 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -28,6 +28,9 @@ properties:
> vdd-supply:
> description: 3.3V power supply.
>
> + vdda-supply:
> + description: 3.3V analog power supply.
> +
> clocks:
> description: External 24MHz clock connected to the CLKIN pin.
> maxItems: 1
> @@ -36,6 +39,18 @@ required:
> - compatible
> - reg
>
> +if:

This should be merged with the existing allOf, which should be moved
down to after the patternProperties section.

Cheers,
Conor.

> + properties:
> + compatible:
> + contains:
> + const: usb424,2514
> +then:
> + properties:
> + vdda-supply: true
> +else:
> + properties:
> + vdda-supply: false
> +
> patternProperties:
> "^.*@[0-9a-f]{1,2}$":
> description: The hard wired USB devices
>
> base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
> prerequisite-patch-id: 0000000000000000000000000000000000000000
> --
> 2.34.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]