Re: [PATCH next 2/3] dt-bindings: usb: microchip,usb2514: add support for USB2512/USB2513

Conor Dooley
2025-02-11T16:44:35Z

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Tue, Feb 11, 2025 at 11:58:38AM +0100, Catalin Popescu wrote:
> Extend support to Microchip hubs USB2512 & USB2513 which are identical
> to USB2514 but offer less downstream ports (i.e. respectively 2 and 3
> ports).
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
> .../bindings/usb/microchip,usb2514.yaml | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index 743f7a22f13d..d159cde04c84 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -14,11 +14,18 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - usb424,2412
> - - usb424,2417
> - - usb424,2514
> - - usb424,2517
> + oneOf:
> + - items:

This items isn't doing anything, as it only has one entry (the enum).

> + - enum:
> + - usb424,2412
> + - usb424,2417
> + - usb424,2514
> + - usb424,2517
> + - items:
> + - enum:
> + - usb424,2512
> + - usb424,2513
> + - const: usb424,2514
>
> reg: true
>
> --
> 2.34.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]