From: Greg KH <gregkh@linuxfoundation.org>
To: Jillian Donahue <jilliandonahue58@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH v3] f_midi_complete to call tasklet_hi_schedule
Date: Tue, 11 Feb 2025 06:59:26 +0100 [thread overview]
Message-ID: <2025021148-expectant-rendering-1019@gregkh> (raw)
In-Reply-To: <CAArt=LhOBqH-qZVkdBsh13Csvv1GrDBqakfPGjpFt0TF8KBYsg@mail.gmail.com>
On Mon, Feb 10, 2025 at 10:18:13AM -0700, Jillian Donahue wrote:
> Ah yea, this error happens because in this commit:
> https://github.com/torvalds/linux/commit/8653d71ce3763aedcf3d2331f59beda3fecd79e4
> the tasklets are replaced with works. Should I request the patch to be
> in v5.10 or should I update the fix to use
> queue_work(system_highpri_wq, &midi->work) ?
>
> > >> drivers/usb/gadget/function/f_midi.c:286:31: error: no member named 'tasklet' in 'struct f_midi'
> > 286 | tasklet_hi_schedule(&midi->tasklet);
> > | ~~~~ ^
> > 1 error generated.
Always submit your changes based on the latest kernel tree (ideally the
latest development tree). Any older kernel backports can happen after
they end up in a release.
thanks,
greg k-h
prev parent reply other threads:[~2025-02-11 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 20:34 [PATCH v3] f_midi_complete to call tasklet_hi_schedule Jill Donahue
2025-02-08 7:14 ` Greg KH
2025-02-08 12:10 ` kernel test robot
2025-02-08 12:42 ` kernel test robot
2025-02-10 17:18 ` Jillian Donahue
2025-02-11 5:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021148-expectant-rendering-1019@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jilliandonahue58@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox