From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm/tcpci_maxim: better interrupt name
Date: Thu, 13 Feb 2025 14:23:34 +0100 [thread overview]
Message-ID: <2025021314-obsolete-modify-2b96@gregkh> (raw)
In-Reply-To: <e5855e6d868b60277c24df01b2f27d8736301932.camel@linaro.org>
On Thu, Feb 13, 2025 at 01:10:49PM +0000, André Draszik wrote:
> Thanks Greg,
>
> On Thu, 2025-02-13 at 12:56 +0100, Greg Kroah-Hartman wrote:
> > At a quick glance, tcpci_register_port() is called earlier in the
> > function, but when you error out here you did not call
> > tcpci_unregister_port(). What else needs to also be unwound?
>
> This driver manages everything using devres, including calling of
> tcpci_unregister_port() via devres:
>
> ret = devm_add_action_or_reset(&client->dev,
> max_tcpci_unregister_tcpci_port,
> chip->tcpci);
>
> is done just after tcpci_register_port(). As far as I can see nothing
> needs to be unwound explicitly.
Ugh, that wasn't obvious at all, sorry about that. Yet another reason
to hate devm apis :)
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-13 13:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 9:37 [PATCH] usb: typec: tcpm/tcpci_maxim: better interrupt name André Draszik
2025-02-13 10:11 ` Greg Kroah-Hartman
2025-02-13 11:44 ` André Draszik
2025-02-13 11:56 ` Greg Kroah-Hartman
2025-02-13 13:10 ` André Draszik
2025-02-13 13:23 ` Greg Kroah-Hartman [this message]
2025-02-14 21:57 ` William McVicker
2025-02-25 8:42 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021314-obsolete-modify-2b96@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andre.draszik@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox