From: Greg KH <gregkh@linuxfoundation.org>
To: Suraj Patil <surajpatil522@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: displayport: Update outdated FIXME comment
Date: Sun, 16 Feb 2025 08:08:50 +0100 [thread overview]
Message-ID: <2025021610-tartness-doorstep-4439@gregkh> (raw)
In-Reply-To: <20250216001609.106616-3-surajpatil522@gmail.com>
On Sun, Feb 16, 2025 at 12:16:09AM +0000, Suraj Patil wrote:
> The port mode is intentionally fixed to DFP_U; remove the FIXME tag.
Really?
>
> Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
> ---
> drivers/usb/typec/altmodes/displayport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index ac84a6d64c2f..732ee9399921 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -727,7 +727,7 @@ int dp_altmode_probe(struct typec_altmode *alt)
> struct fwnode_handle *fwnode;
> struct dp_altmode *dp;
>
> - /* FIXME: Port can only be DFP_U. */
> + /* Port mode is fixed to DFP_U. */
Are you sure this can be removed? I read this as this is a problem and
needs to be fixed in the future sometime, why is this suddenly not a
problem? What commit id fixed it?
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-16 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 0:16 [PATCH] docs: Fix typo in aspeed-lpc.yaml Suraj Patil
2025-02-16 0:16 ` [PATCH] docs: Fix typo in usb/CREDITS Suraj Patil
2025-02-16 0:16 ` [PATCH] usb: typec: displayport: Update outdated FIXME comment Suraj Patil
2025-02-16 7:08 ` Greg KH [this message]
[not found] ` <CACuQ1FJPV7BNr6CKfzOUNDCtoygvNY3NuvnyNV0hCk_uFwLjmg@mail.gmail.com>
2025-02-16 13:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021610-tartness-doorstep-4439@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=surajpatil522@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox