Re: [PATCH 2/2] usb: dwc3: Don't use %pK through printk

Thinh Nguyen
2025-02-19T22:43:51Z

On Mon, Feb 17, 2025, Thomas Weißschuh wrote:
> Restricted pointers ("%pK") are not meant to be used through printk().
> It can unintentionally expose security sensitive, raw pointer values.
>
> Use regular pointer formatting instead.
>
> Link: https://urldefense.com/v3/__https://lore.kernel.org/lkml/20250113171731-dc10e3c1-da64-4af0-b767-7c7070468023@linutronix.de/__;!!A4F2R9G_pg!aL6340JEjoiSy7grYBE9C7kitN3lR7BsH4zWSkY6QKPCrC_SDBPIL8rZaoIXxABAdIRsEC2YPI_AtCU9tMrD1byOXeZ93YpywfAFLw$
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> drivers/usb/dwc3/dwc3-st.c | 2 +-
> drivers/usb/dwc3/gadget.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index ef7c43008946e15b72d88aba4941dc52bf0788d7..5d513decaacd22de15825dc061c2747cf09fef07 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -225,7 +225,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>
> dwc3_data->syscfg_reg_off = res->start;
>
> - dev_vdbg(dev, "glue-logic addr 0x%pK, syscfg-reg offset 0x%x\n",
> + dev_vdbg(dev, "glue-logic addr 0x%p, syscfg-reg offset 0x%x\n",
> dwc3_data->glue_base, dwc3_data->syscfg_reg_off);
>
> struct device_node *child __free(device_node) = of_get_compatible_child(node,
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index ddd6b2ce57107cb62c5cec02eae3fe3524164469..7ea1dcd07f02999c913f1520ec05bbcf1a43d8d5 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -1971,12 +1971,12 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req)
> return -ESHUTDOWN;
> }
>
> - if (WARN(req->dep != dep, "request %pK belongs to '%s'\n",
> + if (WARN(req->dep != dep, "request %p belongs to '%s'\n",
> &req->request, req->dep->name))
> return -EINVAL;
>
> if (WARN(req->status < DWC3_REQUEST_STATUS_COMPLETED,
> - "%s: request %pK already in flight\n",
> + "%s: request %p already in flight\n",
> dep->name, &req->request))
> return -EINVAL;
>
> @@ -2165,7 +2165,7 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
> }
> }
>
> - dev_err(dwc->dev, "request %pK was not queued to %s\n",
> + dev_err(dwc->dev, "request %p was not queued to %s\n",
> request, ep->name);
> ret = -EINVAL;
> out:
>
> --
> 2.48.1
>

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks,
Thinh