From: Niklas Neronin <niklas.neronin@linux.intel.com>
To: mathias.nyman@linux.intel.com
Cc: linux-usb@vger.kernel.org,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: [PATCH v4 0/2] usb: xhci: page size improvements
Date: Thu, 20 Feb 2025 16:40:35 +0200 [thread overview]
Message-ID: <20250220144037.2723533-1-niklas.neronin@linux.intel.com> (raw)
Correct off-by-one page size debug message.
Set page size to the xHCI-supported size, instead of 4KB.
Clarified the interpretation of the xHCI spec 1.9 regarding page size.
The correct interpretation is that only one bit is set, indicating the
only supported page size. This is supported by the following sources:
Section 6.6.1, PSZ:
The PSZ calculation uses the page size bit and would not work with
multiple bits set.
Section 7.7, Implementation Notes:
"This version of the xHCI spec only allows an implementation to support
a single page size, as reported by the PAGESIZE register."
Version 4 changes:
* Replace manual power of 2 check with is_power_of_2()
Version 3 changes:
* Rebase agains Linux 6.14-rc1.
* Repalce variable int 'i' with unsigned int 'val'.
* Rename temp variable 'page_shift' to 'page_size'.
Version 2 changes:
* Added handling for invalid page size register values.
Niklas Neronin (2):
usb: xhci: correct debug message page size calculation
usb: xhci: set page size to the xHCI-supported size
drivers/usb/host/xhci-mem.c | 34 ++++++++++++++++++----------------
drivers/usb/host/xhci.h | 8 ++++----
2 files changed, 22 insertions(+), 20 deletions(-)
--
2.47.2
next reply other threads:[~2025-02-20 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 14:40 Niklas Neronin [this message]
2025-02-20 14:40 ` [PATCH v4 1/2] usb: xhci: correct debug message page size calculation Niklas Neronin
2025-02-20 14:40 ` [PATCH v4 2/2] usb: xhci: set page size to the xHCI-supported size Niklas Neronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220144037.2723533-1-niklas.neronin@linux.intel.com \
--to=niklas.neronin@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox