From: Greg KH <gregkh@linuxfoundation.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: stern@rowland.harvard.edu, christophe.jaillet@wanadoo.fr,
mka@chromium.org, make_ruc2021@163.com,
javier.carrasco@wolfvision.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] usb: core: Add error handling in usb_reset_device for autoresume failure
Date: Thu, 20 Feb 2025 11:15:37 +0100 [thread overview]
Message-ID: <2025022046-clinking-levitate-9fbf@gregkh> (raw)
In-Reply-To: <20250220095218.970-1-vulab@iscas.ac.cn>
On Thu, Feb 20, 2025 at 05:52:18PM +0800, Wentao Liang wrote:
> In usb_reset_device(), the function continues execution and
> calls usb_autosuspend_device() after usb_autosuspend_device fails.
>
> To fix this, add error handling for usb_autoresume_device()
> and return the error code immediately. This ensures that
> usb_autosuspend_device() is not called when usb_autoresume_device()
> fails, maintaining device state consistency.
>
> Fixes: 94fcda1f8ab5 ("usbcore: remove unused argument in autosuspend")
> Cc: stable@vger.kernel.org # 2.6.20+
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/usb/core/hub.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 21ac9b464696..f2efdbdd1533 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -6292,7 +6292,9 @@ int usb_reset_device(struct usb_device *udev)
> noio_flag = memalloc_noio_save();
>
> /* Prevent autosuspend during the reset */
> - usb_autoresume_device(udev);
Have you ever seen this function fail?
> + ret = usb_autoresume_device(udev);
> + if (ret < 0)
if (ret) please.
Also, how was this tested? How was it found?
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-20 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:52 [PATCH] usb: core: Add error handling in usb_reset_device for autoresume failure Wentao Liang
2025-02-20 10:15 ` Greg KH [this message]
2025-02-20 10:22 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025022046-clinking-levitate-9fbf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=javier.carrasco@wolfvision.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=make_ruc2021@163.com \
--cc=mka@chromium.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox