Re: So, I had to revert d6d458d42e1 ("Handle DisplayPort tunnel activation asynchronously") too, to stop my resume crashes

[Mika Westerberg <mika.westerberg@linux.intel.com>]

Hi Kenneth,

Like discussed, let's deal one issue at the time.

It is really hard to debug anything if you keep changing the steps so
please let's keep these as separate issues:

1) Hang/crash during resume when dock + NVMe is disconnected before resume.
2) Monitor issue over DP tunnel.

For the first is this now solved if you revert
9d573d19547b3fae0c1d4e5fce52bdad3fda3664?

You can "isolate" this to PCIe side completely by doing the steps with the
commit but don't connect any monitors. Then you can do the steps (just
these , don't throw in any additional steps unless you think they are
needed but then mention them):

1. Boot the system up, nothing connected.
2. Connect TBT 4 dock to the host (no monitors)
3. Connect TBT 3 NVMe to the TBT 4 dock (no monitors)
4. Verify that the PCIe devices such as the NVMe are visible and working.
5. Suspend the system by closing the lid.
6. Unplug the device chain from the host.
7. Resume the system by opening the lid.

Expectation: System resumes just fine, PCIe devices are gone but system is
responsive.
Actual result: System does not resume and is not responsive.

If this gets solved by the revert then that's one issue nailed, good.

----------------------------------

For the second issue, I'm not sure I know the steps but since you mention
reverting d6d458d42e1e ("thunderbolt: Handle DisplayPort tunnel activation
asynchronously"), it should trigger pretty much any time you plug in
monitor so we can follow different and hopefully simpler steps:

1. Boot the system up, nothing connected.
2. Connect TBT 4 dock to the system.
3. Connect monitor to the TBT 4 dock.

Expectation: Monitor shows the screen properly.
Actual result: Blank screen.

For this issue please enable "thunderbolt.dyndbg=p+" in the kernel command
line so we can see in the dmesg what is going on. Once you reproduce (if
above steps then no need to mention, if different steps mention exactly the
simplest steps you do to reproduce) provide full dmesg of this run. I will
then take a look.

Thanks!

On Sun, Mar 02, 2025 at 08:30:55AM -0800, Kenneth Crudup wrote:
> 
> Forgot to add the dmesg.
> 
> -K
> 
> On 3/2/25 08:26, Kenneth Crudup wrote:
> > 
> > FWIW, seeing a Metric F'ton (13171) of these after testing a hibernate
> > cycle- I guess now that my resumes are completing these are occurring
> > now:
> > 
> > thunderbolt 0000:00:0d.3: hotplug event from non existent switch 1:d
> > (unplug: 0)
> > 
> > This is one of my onboard ports (presumably the right one I use all the
> > time at home):
> > 
> > ----
> > 0000:00:0d.3 USB controller [0c03]: Intel Corporation Alder Lake-P
> > Thunderbolt 4 NHI #1 [8086:466d] (rev 02) (prog-if 40 [USB4 Host
> > Interface])
> >          Subsystem: Dell Device [1028:0af3]
> >          Flags: bus master, fast devsel, latency 0, IRQ 16, IOMMU group 8
> >          Memory at 6040200000 (64-bit, non-prefetchable) [size=256K]
> >          Memory at 60402e3000 (64-bit, non-prefetchable) [size=4K]
> >          Capabilities: [80] Power Management version 3
> >          Capabilities: [88] MSI: Enable- Count=1/1 Maskable- 64bit+
> >          Capabilities: [a0] MSI-X: Enable+ Count=16 Masked-
> >          Kernel driver in use: thunderbolt
> > ----
> > 
> > -K
> > 
> 
> -- 
> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County
> CA