From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kenneth Crudup <kenny@panix.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: So, I had to revert d6d458d42e1 ("Handle DisplayPort tunnel activation asynchronously") too, to stop my resume crashes
Date: Mon, 3 Mar 2025 15:23:27 +0200 [thread overview]
Message-ID: <20250303132327.GW3713119@black.fi.intel.com> (raw)
In-Reply-To: <744090aa-074e-443f-8a94-567dadff4c7d@panix.com>
On Mon, Mar 03, 2025 at 05:19:27AM -0800, Kenneth Crudup wrote:
>
> >> Oh and the failure mode for d6d458d4 is ALWAYS this, and always(?) from
> line
> >> 436/7 of ".../drivers/thunderbolt/path.c", a call to tb_port_write():
>
> I was looking thru the pstore dumps; it may not ALWAYS be line 436, but it
> is always in "tb_port_write()".
>
> On 3/3/25 05:13, Mika Westerberg wrote:
>
> > That's also weird because we don't do anything for DP tunnels on resume so
> > what this code is doing is to clean up for the tunnels left by the boot
> > kernel (since this is hibernate).
>
> OK, but for completeness' sake the crash happens on a suspend resume as well
> (and the same failure mode as a resume hibernate).
On suspend/resume we don't do anything for the DP tunnels, not even clean
up anything as compared to hibernate so it's double weird that at that
point d6d458d4 affects it in any way.
Since if it is happening over suspend resume, I suggest we stick with that
for repro because it involves simpler code paths.
next prev parent reply other threads:[~2025-03-03 13:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 4:57 So, I had to revert d6d458d42e1 ("Handle DisplayPort tunnel activation asynchronously") too, to stop my resume crashes Kenneth Crudup
2025-03-02 5:36 ` Kenneth Crudup
2025-03-02 16:26 ` Kenneth Crudup
2025-03-02 16:30 ` Kenneth Crudup
2025-03-03 10:46 ` Mika Westerberg
2025-03-03 11:02 ` Kenneth Crudup
2025-03-03 11:21 ` Mika Westerberg
2025-03-03 11:38 ` Kenneth Crudup
2025-03-03 11:45 ` Kenneth Crudup
2025-03-03 11:55 ` Mika Westerberg
2025-03-03 12:39 ` Kenneth Crudup
2025-03-03 12:51 ` Kenneth Crudup
2025-03-03 11:53 ` Mika Westerberg
2025-03-03 12:33 ` Kenneth Crudup
2025-03-03 13:13 ` Mika Westerberg
2025-03-03 13:19 ` Kenneth Crudup
2025-03-03 13:23 ` Mika Westerberg [this message]
2025-03-03 13:46 ` Mika Westerberg
2025-03-03 13:53 ` Kenneth Crudup
2025-03-03 14:01 ` Mika Westerberg
2025-03-03 14:10 ` Kenneth Crudup
2025-03-03 14:20 ` Mika Westerberg
2025-03-03 14:33 ` Kenneth Crudup
2025-03-03 17:58 ` Mika Westerberg
2025-03-03 18:20 ` Kenneth Crudup
2025-03-03 19:44 ` Kenneth Crudup
2025-03-04 8:27 ` Mika Westerberg
2025-03-04 12:52 ` Kenneth Crudup
2025-03-04 13:40 ` Mika Westerberg
2025-03-04 13:48 ` Kenneth Crudup
2025-03-04 13:51 ` Mika Westerberg
2025-03-04 17:29 ` Kenneth Crudup
2025-03-05 8:31 ` Mika Westerberg
2025-03-03 14:17 ` Kenneth Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303132327.GW3713119@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=kenny@panix.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox