Re: [PATCH] usb: dwc3: Set SUSPENDENABLE soon after phy init

[Thinh Nguyen <Thinh.Nguyen@synopsys.com>]

Hi Greg,

On Thu, Jan 30, 2025, Thinh Nguyen wrote:
> After phy initialization, some phy operations can only be executed while
> in lower P states. Ensure GUSB3PIPECTL.SUSPENDENABLE and
> GUSB2PHYCFG.SUSPHY are set soon after initialization to avoid blocking
> phy ops.
> 
> Previously the SUSPENDENABLE bits are only set after the controller
> initialization, which may not happen right away if there's no gadget
> driver or xhci driver bound. Revise this to clear SUSPENDENABLE bits
> only when there's mode switching (change in GCTL.PRTCAPDIR).
> 
> Fixes: 6d735722063a ("usb: dwc3: core: Prevent phy suspend during init")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> ---
>  drivers/usb/dwc3/core.c | 69 +++++++++++++++++++++++++----------------
>  drivers/usb/dwc3/core.h |  2 +-
>  drivers/usb/dwc3/drd.c  |  4 +--
>  3 files changed, 45 insertions(+), 30 deletions(-)
> 


Just checking, I hope this patch isn't lost in your inbox. If not, then
you can ignore this message.

BR,
Thinh