From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82D64AD27; Mon, 3 Mar 2025 09:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740993410; cv=none; b=TTK4NcdtllABfmqKGSmx+soFmF7papWDqMBQAu4aq1wEPbsWhj0cc8M+dfdB4sBxkFgc8l5A5NseWnViZbR7/b+n95nr20csfy3mcPbffyZUd7tseqROQ6T0L6cDh1lmBqg17LxRzxsG9SzVuZDmwc1h6JsOx+z158cYBCd4sGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740993410; c=relaxed/simple; bh=8C2lBBTuOzy/gLEQfKKi7QGhxyqvHea5OqVTrvMiUmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DJa5epGg/nbNdpUYRASKezJGSYaOzn0EaROpey/5G/XTLXdSoDXoU0g2Z+jauETHAReh+ygZlBMq/+91u2ClBnAVp5++LWFKZhXyzIjpJ4oktABGVRXHkXgxKXEDWsvBMO9J/pXi6UM75BMHTiQNf0g87RlJ1Rry6+eEbbSti/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QwuxhhjI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QwuxhhjI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F66C4CED6; Mon, 3 Mar 2025 09:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740993409; bh=8C2lBBTuOzy/gLEQfKKi7QGhxyqvHea5OqVTrvMiUmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QwuxhhjI/EWQk7boFqZGYsECDM09hqPvPD9oeDXW2xXJMFcVx+FDw9FPPT5dL7NFM d7z8+pLnWoRYqWZhx9/BS1P03UD2VTC12HY5yIa8PnlATukc7Un4T0sSIsGZEuPzjE QxdEfMQmEujHulpARR+K81sjc84jONwTNHyRHOf8= Date: Mon, 3 Mar 2025 10:16:46 +0100 From: Greg KH To: Miao Li Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Miao Li Subject: Re: [PATCH] usb: quirks: Add DELAY_INIT and NO_LPM for Prolific PL2303 Serial Port Message-ID: <2025030339-morbidly-relax-80c0@gregkh> References: <20250303070047.153591-1-limiao870622@163.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303070047.153591-1-limiao870622@163.com> On Mon, Mar 03, 2025 at 03:00:47PM +0800, Miao Li wrote: > From: Miao Li > > When used on Huawei hisi platforms, Prolific PL2303 Serial Port which > the VID:PID is in 067b:2731 might fail to enumerate at boot time and > doesn't work well with LPM enabled, combination quirks: > USB_QUIRK_DELAY_INIT + USB_QUIRK_NO_LPM > fixed the problems. > > Signed-off-by: Miao Li > --- > drivers/usb/core/quirks.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index dfcfc142bd5e..8aca5518e003 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -341,6 +341,10 @@ static const struct usb_device_id usb_quirk_list[] = { > { USB_DEVICE(0x0638, 0x0a13), .driver_info = > USB_QUIRK_STRING_FETCH_255 }, > > + /* Prolific PL2303 Serial Port */ > + { USB_DEVICE(0x067b, 0x2731), .driver_info = USB_QUIRK_DELAY_INIT | > + USB_QUIRK_NO_LPM }, But this is not the device id for a pl2303 device (or at least one that Linux supports), so how was this tested? And why would this device suddenly stop working? This chipset has been working with Linux for decades now, what is new about this device that requires this change? thanks, greg k-h