public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: raoxu <raoxu@uniontech.com>
To: mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	wangyuli@uniontech.com, zhanjun@uniontech.com,
	raoxu@uniontech.com
Subject: Re:[PATCH V2] usb: xhci: Add debugfs support for xHCI port bandwidth
Date: Tue,  4 Mar 2025 20:51:15 +0800	[thread overview]
Message-ID: <20250304125115.29332-1-raoxu@uniontech.com> (raw)

On 2025/3/4 20:31, Mathias Nyman  wrote:

>I do however have some larger rework suggestions to this.
>
>Instead of queuing three commands on one file read, parsing and
>copy the content from each context dma into an array on stack, we could
>have separate files in debugfs for each speed, and queue one command
>for each. we could also skip the array on stack and print values from context
>directly.
>
>Something is also very off with the locks in this patch.
>Looks like every lock/unlock got replaced with an unlock

thanks Mathias Nyman,

Thank you for your valuable suggestions.I will separate files in debugfs for each speed.
skipping the array on stack and print values from context directly sounds good. looks is a error and i will fix it.
According to your suggestion i will send patch v3

thanks,

raoxu

             reply	other threads:[~2025-03-04 12:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 12:51 raoxu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-03-04  7:09 Re:[PATCH V2] usb: xhci: Add debugfs support for xHCI port bandwidth raoxu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304125115.29332-1-raoxu@uniontech.com \
    --to=raoxu@uniontech.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=wangyuli@uniontech.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox