public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michał Pecio" <michal.pecio@gmail.com>
To: "Neronin, Niklas" <niklas.neronin@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>, linux-usb@vger.kernel.org
Subject: Re: My transfer ring grew to 740 segments
Date: Fri, 14 Mar 2025 09:10:39 +0100	[thread overview]
Message-ID: <20250314091039.1c056383@foxbook> (raw)
In-Reply-To: <f72545d9-a892-4101-9d06-c75979aecbe6@linux.intel.com>

On Thu, 13 Mar 2025 11:45:30 +0200, Neronin, Niklas wrote:

> IMO the driver used to print a long and repetitive debug message,
> which is why I changed it.
> Admittedly, my design does not handle hundreds of segments well.
> 
> Before:
>   For each segment or until the segment containing the TD end TRB:
> 	"Looking for event-dma %016llx trb-start %016llx trb-end %016llx seg-start %016llx seg-end %016llx"
> 
> After:
>   "Event dma %pad for ep %d status %d not part of TD at %016llx - %016llx"
>   For each segment:
> 	"Ring seg %u dma %pad"
> 
> Probably, would have been better to loop from TD start seg to end seg.

That's actually what the old code did, it only printed segments which
contained parts of the TD. Usually one, sometimes two.

New version always prints at least two lines.

I thought that maybe you wanted it for some reason, but if it was only
a matter preserving the old annoying behavior, I think it can go away :)


Regards,
Michal

  reply	other threads:[~2025-03-14  8:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 22:41 My transfer ring grew to 740 segments Michał Pecio
2025-03-12 13:37 ` Mathias Nyman
2025-03-13  7:54   ` Michał Pecio
2025-03-13  8:46 ` Michał Pecio
2025-03-13  9:45   ` Neronin, Niklas
2025-03-14  8:10     ` Michał Pecio [this message]
2025-03-13 14:43   ` Mathias Nyman
2025-03-14 19:15 ` David Laight
2025-03-16 10:27   ` Michał Pecio
2025-03-16 13:20     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314091039.1c056383@foxbook \
    --to=michal.pecio@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=niklas.neronin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox