[PATCH] usb: remove the invalid comments

[PATCH] usb: remove the invalid comments

[Li Qiong]

These function don't return value, remove the invalid comments.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
 drivers/usb/cdns3/cdns3-plat.c      | 2 --
 drivers/usb/gadget/udc/udc-xilinx.c | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
index 59ec505e198a..735df88774e4 100644
--- a/drivers/usb/cdns3/cdns3-plat.c
+++ b/drivers/usb/cdns3/cdns3-plat.c
@@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
 /**
  * cdns3_plat_remove() - unbind drd driver and clean up
  * @pdev: Pointer to Linux platform device
- *
- * Returns 0 on success otherwise negative errno
  */
 static void cdns3_plat_remove(struct platform_device *pdev)
 {
diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index ae2aeb271897..fa94cc065274 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -2178,8 +2178,6 @@ static int xudc_probe(struct platform_device *pdev)
 /**
  * xudc_remove - Releases the resources allocated during the initialization.
  * @pdev: pointer to the platform device structure.
- *
- * Return: 0 always
  */
 static void xudc_remove(struct platform_device *pdev)
 {
-- 
2.30.2

Re: [PATCH] usb: remove the invalid comments

[Greg Kroah-Hartman]

On Fri, Mar 14, 2025 at 03:09:21PM +0800, Li Qiong wrote:
> These function don't return value, remove the invalid comments.
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>  drivers/usb/cdns3/cdns3-plat.c      | 2 --
>  drivers/usb/gadget/udc/udc-xilinx.c | 2 --

This should be 2 different patches, right?

thanks,

greg k-h

Re: [PATCH] usb: remove the invalid comments

[liqiong]

在 2025/3/14 15:12, Greg Kroah-Hartman 写道:
> On Fri, Mar 14, 2025 at 03:09:21PM +0800, Li Qiong wrote:
>> These function don't return value, remove the invalid comments.
>>
>> Signed-off-by: Li Qiong <liqiong@nfschina.com>
>> ---
>>  drivers/usb/cdns3/cdns3-plat.c      | 2 --
>>  drivers/usb/gadget/udc/udc-xilinx.c | 2 --
> This should be 2 different patches, right?
Yeah, I will split this patch and send again.
thanks.



>
> thanks,
>
> greg k-h

[PATCH v2 1/2] usb: cdns3: Remove the invalid comment

[Li Qiong]

The function don't return value, remove the invalid comment.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
 drivers/usb/cdns3/cdns3-plat.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
index 59ec505e198a..735df88774e4 100644
--- a/drivers/usb/cdns3/cdns3-plat.c
+++ b/drivers/usb/cdns3/cdns3-plat.c
@@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
 /**
  * cdns3_plat_remove() - unbind drd driver and clean up
  * @pdev: Pointer to Linux platform device
- *
- * Returns 0 on success otherwise negative errno
  */
 static void cdns3_plat_remove(struct platform_device *pdev)
 {
-- 
2.30.2

[PATCH v2 2/2] usb: gadget: udc-xilinx: Remove the invalid comment

[Li Qiong]

The function don't return value, remove the invalid comment.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
 drivers/usb/gadget/udc/udc-xilinx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index ae2aeb271897..fa94cc065274 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -2178,8 +2178,6 @@ static int xudc_probe(struct platform_device *pdev)
 /**
  * xudc_remove - Releases the resources allocated during the initialization.
  * @pdev: pointer to the platform device structure.
- *
- * Return: 0 always
  */
 static void xudc_remove(struct platform_device *pdev)
 {
-- 
2.30.2

Re: [PATCH v2 1/2] usb: cdns3: Remove the invalid comment

[Greg Kroah-Hartman]

On Fri, Mar 14, 2025 at 04:02:48PM +0800, Li Qiong wrote:
> The function don't return value, remove the invalid comment.
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>  drivers/usb/cdns3/cdns3-plat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
> index 59ec505e198a..735df88774e4 100644
> --- a/drivers/usb/cdns3/cdns3-plat.c
> +++ b/drivers/usb/cdns3/cdns3-plat.c
> @@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>  /**
>   * cdns3_plat_remove() - unbind drd driver and clean up
>   * @pdev: Pointer to Linux platform device
> - *
> - * Returns 0 on success otherwise negative errno
>   */
>  static void cdns3_plat_remove(struct platform_device *pdev)
>  {
> -- 
> 2.30.2
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v2 1/2] usb: cdns3: Remove the invalid comment

[liqiong]

在 2025/3/14 16:19, Greg Kroah-Hartman 写道:
> On Fri, Mar 14, 2025 at 04:02:48PM +0800, Li Qiong wrote:
>> The function don't return value, remove the invalid comment.
>>
>> Signed-off-by: Li Qiong <liqiong@nfschina.com>
>> ---
>>  drivers/usb/cdns3/cdns3-plat.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
>> index 59ec505e198a..735df88774e4 100644
>> --- a/drivers/usb/cdns3/cdns3-plat.c
>> +++ b/drivers/usb/cdns3/cdns3-plat.c
>> @@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>>  /**
>>   * cdns3_plat_remove() - unbind drd driver and clean up
>>   * @pdev: Pointer to Linux platform device
>> - *
>> - * Returns 0 on success otherwise negative errno
>>   */
>>  static void cdns3_plat_remove(struct platform_device *pdev)
>>  {
>> -- 
>> 2.30.2
>>
>>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - This looks like a new version of a previously submitted patch, but you
>   did not list below the --- line any changes from the previous version.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/process/submitting-patches.rst for what
>   needs to be done here to properly describe this.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot

Thanks, I will  resend v3 patch.

[PATCH v3 1/2] usb: cdns3: Remove the invalid comment

[Li Qiong]

The function don't return value, remove the invalid comment.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
v2: Split the first patch to two patches.
v3: Add changes from the previous version.

 drivers/usb/cdns3/cdns3-plat.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
index 59ec505e198a..735df88774e4 100644
--- a/drivers/usb/cdns3/cdns3-plat.c
+++ b/drivers/usb/cdns3/cdns3-plat.c
@@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
 /**
  * cdns3_plat_remove() - unbind drd driver and clean up
  * @pdev: Pointer to Linux platform device
- *
- * Returns 0 on success otherwise negative errno
  */
 static void cdns3_plat_remove(struct platform_device *pdev)
 {
-- 
2.30.2

[PATCH v3 2/2] usb: gadget: udc-xilinx: Remove the invalid comment

[Li Qiong]

The function don't return value, remove the invalid comment.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
---
v2: Split the first patch to two patches.
v3: Add changes from the previous version.

 drivers/usb/gadget/udc/udc-xilinx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index ae2aeb271897..fa94cc065274 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -2178,8 +2178,6 @@ static int xudc_probe(struct platform_device *pdev)
 /**
  * xudc_remove - Releases the resources allocated during the initialization.
  * @pdev: pointer to the platform device structure.
- *
- * Return: 0 always
  */
 static void xudc_remove(struct platform_device *pdev)
 {
-- 
2.30.2

Re: [PATCH v3 1/2] usb: cdns3: Remove the invalid comment

[Peter Chen (CIX)]

On 25-03-14 18:16:38, Li Qiong wrote:
> The function don't return value, remove the invalid comment.
> 
> Signed-off-by: Li Qiong <liqiong@nfschina.com>

Acked-by: Peter Chen <peter.chen@kernel.org>

> ---
> v2: Split the first patch to two patches.
> v3: Add changes from the previous version.
> 
>  drivers/usb/cdns3/cdns3-plat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
> index 59ec505e198a..735df88774e4 100644
> --- a/drivers/usb/cdns3/cdns3-plat.c
> +++ b/drivers/usb/cdns3/cdns3-plat.c
> @@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>  /**
>   * cdns3_plat_remove() - unbind drd driver and clean up
>   * @pdev: Pointer to Linux platform device
> - *
> - * Returns 0 on success otherwise negative errno
>   */
>  static void cdns3_plat_remove(struct platform_device *pdev)
>  {
> -- 
> 2.30.2
> 

-- 

Best regards,
Peter