Re: [PATCH v2] usb: typec: ucsi: Add the UCSI commands in debugfs

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Mar 28, 2025 at 03:13:05PM +0530, madhu.m@intel.com wrote:
> From: Madhu M <madhu.m@intel.com>
> 
> Added the UCSI commands UCSI_GET_CAM_SUPPORTED, UCSI_GET_PD_MESSAGE,
> UCSI_GET_ATTENTION_VDO and UCSI_SET_USB support in debugfs to enhance
> PD/TypeC debugging capability.
> 
> Signed-off-by: Madhu M <madhu.m@intel.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/usb/typec/ucsi/debugfs.c | 4 ++++
>  drivers/usb/typec/ucsi/ucsi.h    | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/debugfs.c b/drivers/usb/typec/ucsi/debugfs.c
> index eae2b18a2d8a..92ebf1a2defd 100644
> --- a/drivers/usb/typec/ucsi/debugfs.c
> +++ b/drivers/usb/typec/ucsi/debugfs.c
> @@ -34,16 +34,20 @@ static int ucsi_cmd(void *data, u64 val)
>  	case UCSI_CONNECTOR_RESET:
>  	case UCSI_SET_SINK_PATH:
>  	case UCSI_SET_NEW_CAM:
> +	case UCSI_SET_USB:
>  		ret = ucsi_send_command(ucsi, val, NULL, 0);
>  		break;
>  	case UCSI_GET_CAPABILITY:
>  	case UCSI_GET_CONNECTOR_CAPABILITY:
>  	case UCSI_GET_ALTERNATE_MODES:
> +	case UCSI_GET_CAM_SUPPORTED:
>  	case UCSI_GET_CURRENT_CAM:
>  	case UCSI_GET_PDOS:
>  	case UCSI_GET_CABLE_PROPERTY:
>  	case UCSI_GET_CONNECTOR_STATUS:
>  	case UCSI_GET_ERROR_STATUS:
> +	case UCSI_GET_PD_MESSAGE:
> +	case UCSI_GET_ATTENTION_VDO:
>  	case UCSI_GET_CAM_CS:
>  	case UCSI_GET_LPM_PPM_INFO:
>  		ret = ucsi_send_command(ucsi, val,
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 3a2c1762bec1..72b9d5a42961 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -123,9 +123,11 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
>  #define UCSI_GET_CONNECTOR_STATUS		0x12
>  #define UCSI_GET_CONNECTOR_STATUS_SIZE		152
>  #define UCSI_GET_ERROR_STATUS			0x13
> +#define UCSI_GET_ATTENTION_VDO			0x16
>  #define UCSI_GET_PD_MESSAGE			0x15
>  #define UCSI_GET_CAM_CS			0x18
>  #define UCSI_SET_SINK_PATH			0x1c
> +#define UCSI_SET_USB				0x21
>  #define UCSI_GET_LPM_PPM_INFO			0x22
>  
>  #define UCSI_CONNECTOR_NUMBER(_num_)		((u64)(_num_) << 16)
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot