From: Greg KH <gregkh@linuxfoundation.org>
To: Frode Isaksen <fisaksen@baylibre.com>
Cc: linux-usb@vger.kernel.org, Thinh.Nguyen@synopsys.com,
Frode Isaksen <frode@meta.com>
Subject: Re: [PATCH] usb: dwc3: gadget: check that event count does not exceed event buffer length
Date: Fri, 28 Mar 2025 10:10:55 +0100 [thread overview]
Message-ID: <2025032841-tactics-linguini-f2ca@gregkh> (raw)
In-Reply-To: <20250328085603.2156517-1-fisaksen@baylibre.com>
On Fri, Mar 28, 2025 at 09:55:25AM +0100, Frode Isaksen wrote:
> From: Frode Isaksen <frode@meta.com>
>
> The event count is read from register DWC3_GEVNTCOUNT.
> There is a check for the count being zero, but not for exceeding the
> event buffer length.
> Check that event count does not exceed event buffer length,
> avoiding an out-of-bounds access when memcpy'ing the event.
> Crash log:
> Unable to handle kernel paging request at virtual address ffffffc0129be000
> pc : __memcpy+0x114/0x180
> lr : dwc3_check_event_buf+0xec/0x348
> x3 : 0000000000000030 x2 : 000000000000dfc4
> x1 : ffffffc0129be000 x0 : ffffff87aad60080
> Call trace:
> __memcpy+0x114/0x180
> dwc3_interrupt+0x24/0x34
>
> Signed-off-by: Frode Isaksen <frode@meta.com>
> ---
> This bug was discovered, tested and fixed (no more crashes seen) on Meta Quest 3 device.
> Also tested on T.I. AM62x board.
What commit id does this fix? Should it go to stable kernels too?
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-28 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 8:55 [PATCH] usb: dwc3: gadget: check that event count does not exceed event buffer length Frode Isaksen
2025-03-28 9:10 ` Greg KH [this message]
2025-03-28 9:57 ` Frode Isaksen
2025-03-28 10:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025032841-tactics-linguini-f2ca@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=fisaksen@baylibre.com \
--cc=frode@meta.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox