* [PATCH v2 1/4] dt-bindings: usb: Introduce usb-hub.yaml
2025-04-15 9:41 [PATCH v2 0/4] Introduce usb-hub.yaml binding and add support for Parade PS5511 Pin-yen Lin
@ 2025-04-15 9:41 ` Pin-yen Lin
2025-04-16 16:52 ` Rob Herring
2025-04-15 9:41 ` [PATCH v2 2/4] dt-bindings: usb: Add binding for PS5511 hub controller Pin-yen Lin
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Pin-yen Lin @ 2025-04-15 9:41 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Kaehlcke
Cc: Stephen Boyd, linux-kernel, Pin-yen Lin, devicetree, linux-usb
Introduce a general USB hub binding that describes downstream ports
and hard wired USB devices for on-board USB hubs.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v2:
- New in v2
.../devicetree/bindings/usb/usb-hub.yaml | 91 +++++++++++++++++++
1 file changed, 91 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/usb-hub.yaml
diff --git a/Documentation/devicetree/bindings/usb/usb-hub.yaml b/Documentation/devicetree/bindings/usb/usb-hub.yaml
new file mode 100644
index 00000000000000..34cd248fa43c2d
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/usb-hub.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/usb-hub.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Generic USB Hub
+
+maintainers:
+ - Pin-yen Lin <treapking@chromium.org>
+
+allOf:
+ - $ref: usb-device.yaml#
+
+properties:
+ compatible: true
+
+ reg: true
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
+ peer-hub:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ phandle to the peer hub on the controller.
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description:
+ The downstream facing USB ports
+
+ patternProperties:
+ "^port@[1-9]$":
+ $ref: /schemas/graph.yaml#/properties/port
+
+patternProperties:
+ '^.*@[1-9]$':
+ description: The hard wired USB devices
+ type: object
+ $ref: /schemas/usb/usb-device.yaml
+ additionalProperties: true
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: true
+
+examples:
+ - |
+ usb {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 2.0 hub on port 1 */
+ hub_2_0: hub@1 {
+ compatible = "usb123,4567";
+ reg = <1>;
+ peer-hub = <&hub_3_0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* USB 2.0 device on port 5 */
+ device@5 {
+ reg = <5>;
+ compatible = "usb765,4321";
+ };
+ };
+
+ /* 3.0 hub on port 2 */
+ hub_3_0: hub@2 {
+ compatible = "usb123,abcd";
+ reg = <2>;
+ peer-hub = <&hub_2_0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* Type-A connector on port 3 */
+ port@3 {
+ reg = <3>;
+ endpoint {
+ remote-endpoint = <&usb_a0_ss>;
+ };
+ };
+ };
+ };
+ };
--
2.49.0.777.g153de2bbd5-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/4] dt-bindings: usb: Add binding for PS5511 hub controller
2025-04-15 9:41 [PATCH v2 0/4] Introduce usb-hub.yaml binding and add support for Parade PS5511 Pin-yen Lin
2025-04-15 9:41 ` [PATCH v2 1/4] dt-bindings: usb: Introduce usb-hub.yaml Pin-yen Lin
@ 2025-04-15 9:41 ` Pin-yen Lin
2025-04-16 18:00 ` Rob Herring
2025-04-15 9:42 ` [PATCH v2 3/4] dt-bindings: usb: realtek,rts5411: Adapt usb-hub.yaml Pin-yen Lin
2025-04-15 9:42 ` [PATCH v2 4/4] usb: misc: onboard_usb_dev: Add Parade PS5511 hub support Pin-yen Lin
3 siblings, 1 reply; 8+ messages in thread
From: Pin-yen Lin @ 2025-04-15 9:41 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Kaehlcke
Cc: Stephen Boyd, linux-kernel, Pin-yen Lin, devicetree, linux-usb
Parade PS5511 is USB hub with 4 USB 3.2 compliant 5Gbps downstream(DS)
ports, and 1 extra USB 2.0 downstream port. The hub has one reset pin
control and two power supplies (3V3 and 1V1).
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v2:
- Inherit usb-hub.yaml
- Fix bindings to reject port@5/device@5 for 3.0 hub correctly
- Minor string fixes
.../bindings/usb/parade,ps5511.yaml | 115 ++++++++++++++++++
1 file changed, 115 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/parade,ps5511.yaml
diff --git a/Documentation/devicetree/bindings/usb/parade,ps5511.yaml b/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
new file mode 100644
index 00000000000000..86c75d69ee35b2
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
@@ -0,0 +1,115 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/parade,ps5511.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Parade PS5511 4+1 Port USB 3.2 Gen 1 Hub Controller
+
+maintainers:
+ - Pin-yen Lin <treapking@chromium.org>
+
+properties:
+ compatible:
+ enum:
+ - usb1da0,5511
+ - usb1da0,55a1
+
+ reg: true
+
+ '#address-cells': true
+
+ '#size-cells': true
+
+ reset-gpios:
+ items:
+ - description: GPIO specifier for RESETB pin.
+
+ vddd11-supply:
+ description:
+ 1V1 power supply to the hub
+
+ vdd33-supply:
+ description:
+ 3V3 power supply to the hub
+
+ peer-hub: true
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ '#address-cells': true
+
+ '#size-cells': true
+
+ patternProperties:
+ '^port@[1-5]$': true
+
+ additionalProperties: false
+
+patternProperties:
+ '^.*@[1-5]$': true
+
+required:
+ - compatible
+ - reg
+ - peer-hub
+
+additionalProperties: false
+
+allOf:
+ - $ref: usb-hub.yaml#
+ - if:
+ not:
+ properties:
+ compatible:
+ enum:
+ - usb1da0,55a1
+ then:
+ properties:
+ ports:
+ properties:
+ port@5: false
+ patternProperties:
+ '^.*@5$': false
+
+examples:
+ - |
+ usb {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 2.0 hub on port 1 */
+ hub_2_0: hub@1 {
+ compatible = "usb1da0,55a1";
+ reg = <1>;
+ peer-hub = <&hub_3_0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* USB 2.0 device on port 5 */
+ device@5 {
+ reg = <5>;
+ compatible = "usb123,4567";
+ };
+ };
+
+ /* 3.0 hub on port 2 */
+ hub_3_0: hub@2 {
+ compatible = "usb1da0,5511";
+ reg = <2>;
+ peer-hub = <&hub_2_0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ /* Type-A connector on port 3 */
+ port@3 {
+ reg = <3>;
+ endpoint {
+ remote-endpoint = <&usb_a0_ss>;
+ };
+ };
+ };
+ };
+ };
--
2.49.0.777.g153de2bbd5-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 3/4] dt-bindings: usb: realtek,rts5411: Adapt usb-hub.yaml
2025-04-15 9:41 [PATCH v2 0/4] Introduce usb-hub.yaml binding and add support for Parade PS5511 Pin-yen Lin
2025-04-15 9:41 ` [PATCH v2 1/4] dt-bindings: usb: Introduce usb-hub.yaml Pin-yen Lin
2025-04-15 9:41 ` [PATCH v2 2/4] dt-bindings: usb: Add binding for PS5511 hub controller Pin-yen Lin
@ 2025-04-15 9:42 ` Pin-yen Lin
2025-04-16 18:01 ` Rob Herring
2025-04-15 9:42 ` [PATCH v2 4/4] usb: misc: onboard_usb_dev: Add Parade PS5511 hub support Pin-yen Lin
3 siblings, 1 reply; 8+ messages in thread
From: Pin-yen Lin @ 2025-04-15 9:42 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Kaehlcke
Cc: Stephen Boyd, linux-kernel, Pin-yen Lin, devicetree, linux-usb
Inherit usb-hub.yaml and remove duplicated schemas.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v2:
- New in v2
.../bindings/usb/realtek,rts5411.yaml | 47 +++++--------------
1 file changed, 13 insertions(+), 34 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
index 6577a61cc07531..52fad201a56c82 100644
--- a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
+++ b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
@@ -10,7 +10,7 @@ maintainers:
- Matthias Kaehlcke <mka@chromium.org>
allOf:
- - $ref: usb-device.yaml#
+ - $ref: usb-hub.yaml#
properties:
compatible:
@@ -21,51 +21,30 @@ properties:
reg: true
- '#address-cells':
- const: 1
+ '#address-cells': true
- '#size-cells':
- const: 0
+ '#size-cells': true
vdd-supply:
description:
phandle to the regulator that provides power to the hub.
- peer-hub:
- $ref: /schemas/types.yaml#/definitions/phandle
- description:
- phandle to the peer hub on the controller.
+ peer-hub: true
ports:
$ref: /schemas/graph.yaml#/properties/ports
-
properties:
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description:
- 1st downstream facing USB port
-
- port@2:
- $ref: /schemas/graph.yaml#/properties/port
- description:
- 2nd downstream facing USB port
-
- port@3:
- $ref: /schemas/graph.yaml#/properties/port
- description:
- 3rd downstream facing USB port
-
- port@4:
- $ref: /schemas/graph.yaml#/properties/port
- description:
- 4th downstream facing USB port
+ '#address-cells': true
+
+ '#size-cells': true
+
+ patternProperties:
+ '^port@[1-4]$': true
+
+ additionalProperties: false
patternProperties:
- '^.*@[1-4]$':
- description: The hard wired USB devices
- type: object
- $ref: /schemas/usb/usb-device.yaml
- additionalProperties: true
+ '^.*@[1-4]$': true
required:
- peer-hub
--
2.49.0.777.g153de2bbd5-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 4/4] usb: misc: onboard_usb_dev: Add Parade PS5511 hub support
2025-04-15 9:41 [PATCH v2 0/4] Introduce usb-hub.yaml binding and add support for Parade PS5511 Pin-yen Lin
` (2 preceding siblings ...)
2025-04-15 9:42 ` [PATCH v2 3/4] dt-bindings: usb: realtek,rts5411: Adapt usb-hub.yaml Pin-yen Lin
@ 2025-04-15 9:42 ` Pin-yen Lin
3 siblings, 0 replies; 8+ messages in thread
From: Pin-yen Lin @ 2025-04-15 9:42 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Kaehlcke
Cc: Stephen Boyd, linux-kernel, Pin-yen Lin, devicetree, linux-usb
Parade PS5511 is 4+1 port USB 3.2 gen 1 hub with a reset pin and two power
supplies (3V3 and 1V1).
Add the support for this hub for the reset pin control and power supply.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
(no changes since v1)
drivers/usb/misc/onboard_usb_dev.c | 3 +++
drivers/usb/misc/onboard_usb_dev.h | 9 +++++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c
index 75ac3c6aa92d0d..91b49e58664d6b 100644
--- a/drivers/usb/misc/onboard_usb_dev.c
+++ b/drivers/usb/misc/onboard_usb_dev.c
@@ -490,6 +490,7 @@ static struct platform_driver onboard_dev_driver = {
#define VENDOR_ID_CYPRESS 0x04b4
#define VENDOR_ID_GENESYS 0x05e3
#define VENDOR_ID_MICROCHIP 0x0424
+#define VENDOR_ID_PARADE 0x1da0
#define VENDOR_ID_REALTEK 0x0bda
#define VENDOR_ID_TI 0x0451
#define VENDOR_ID_VIA 0x2109
@@ -580,6 +581,8 @@ static const struct usb_device_id onboard_dev_id_table[] = {
{ USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2517) }, /* USB2517 USB 2.0 HUB */
{ USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2744) }, /* USB5744 USB 2.0 HUB */
{ USB_DEVICE(VENDOR_ID_MICROCHIP, 0x5744) }, /* USB5744 USB 3.0 HUB */
+ { USB_DEVICE(VENDOR_ID_PARADE, 0x5511) }, /* PS5511 USB 3.2 */
+ { USB_DEVICE(VENDOR_ID_PARADE, 0x55a1) }, /* PS5511 USB 2.0 */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 HUB */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 HUB */
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */
diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
index 933797a7e0841c..2963689958fc2a 100644
--- a/drivers/usb/misc/onboard_usb_dev.h
+++ b/drivers/usb/misc/onboard_usb_dev.h
@@ -38,6 +38,13 @@ static const struct onboard_dev_pdata microchip_usb5744_data = {
.is_hub = true,
};
+static const struct onboard_dev_pdata parade_ps5511_data = {
+ .reset_us = 500,
+ .num_supplies = 2,
+ .supply_names = { "vddd11", "vdd33"},
+ .is_hub = true,
+};
+
static const struct onboard_dev_pdata realtek_rts5411_data = {
.reset_us = 0,
.num_supplies = 1,
@@ -122,6 +129,8 @@ static const struct of_device_id onboard_dev_match[] = {
{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },
{ .compatible = "usbbda,5414", .data = &realtek_rts5411_data, },
+ { .compatible = "usb1da0,5511", .data = ¶de_ps5511_data, },
+ { .compatible = "usb1da0,55a1", .data = ¶de_ps5511_data, },
{ .compatible = "usb2109,817", .data = &vialab_vl817_data, },
{ .compatible = "usb2109,2817", .data = &vialab_vl817_data, },
{ .compatible = "usb20b1,0013", .data = &xmos_xvf3500_data, },
--
2.49.0.777.g153de2bbd5-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread