From: kernel test robot <lkp@intel.com>
To: Zongmin Zhou <min_halo@163.com>, skhan@linuxfoundation.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
gregkh@linuxfoundation.org, i@zenithal.me,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
shuah@kernel.org, valentina.manea.m@gmail.com,
Zongmin Zhou <zhouzongmin@kylinos.cn>
Subject: Re: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver
Date: Wed, 23 Apr 2025 09:02:01 +0800 [thread overview]
Message-ID: <202504230805.MkmxQyas-lkp@intel.com> (raw)
In-Reply-To: <20250422063409.607859-1-min_halo@163.com>
Hi Zongmin,
kernel test robot noticed the following build errors:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master v6.15-rc3 next-20250422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zongmin-Zhou/usbip-set-the-dma-mask-to-64bit-default-for-vhci-driver/20250422-143646
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20250422063409.607859-1-min_halo%40163.com
patch subject: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver
config: arm-randconfig-004-20250423 (https://download.01.org/0day-ci/archive/20250423/202504230805.MkmxQyas-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250423/202504230805.MkmxQyas-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504230805.MkmxQyas-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/usb/usbip/vhci_hcd.c:1349:2: error: call to undeclared function 'dma_set_mask'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1349 | dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
| ^
drivers/usb/usbip/vhci_hcd.c:1349:2: note: did you mean 'xa_set_mark'?
include/linux/xarray.h:361:6: note: 'xa_set_mark' declared here
361 | void xa_set_mark(struct xarray *, unsigned long index, xa_mark_t);
| ^
>> drivers/usb/usbip/vhci_hcd.c:1349:27: error: call to undeclared function 'DMA_BIT_MASK'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1349 | dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
| ^
2 errors generated.
vim +/dma_set_mask +1349 drivers/usb/usbip/vhci_hcd.c
1338
1339 static int vhci_hcd_probe(struct platform_device *pdev)
1340 {
1341 struct vhci *vhci = *((void **)dev_get_platdata(&pdev->dev));
1342 struct usb_hcd *hcd_hs;
1343 struct usb_hcd *hcd_ss;
1344 int ret;
1345
1346 usbip_dbg_vhci_hc("name %s id %d\n", pdev->name, pdev->id);
1347
1348 /* Set the dma mask to support 64bit for vhci-hcd driver. */
> 1349 dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
1350
1351 /*
1352 * Allocate and initialize hcd.
1353 * Our private data is also allocated automatically.
1354 */
1355 hcd_hs = usb_create_hcd(&vhci_hc_driver, &pdev->dev, dev_name(&pdev->dev));
1356 if (!hcd_hs) {
1357 pr_err("create primary hcd failed\n");
1358 return -ENOMEM;
1359 }
1360 hcd_hs->has_tt = 1;
1361
1362 /*
1363 * Finish generic HCD structure initialization and register.
1364 * Call the driver's reset() and start() routines.
1365 */
1366 ret = usb_add_hcd(hcd_hs, 0, 0);
1367 if (ret != 0) {
1368 pr_err("usb_add_hcd hs failed %d\n", ret);
1369 goto put_usb2_hcd;
1370 }
1371
1372 hcd_ss = usb_create_shared_hcd(&vhci_hc_driver, &pdev->dev,
1373 dev_name(&pdev->dev), hcd_hs);
1374 if (!hcd_ss) {
1375 ret = -ENOMEM;
1376 pr_err("create shared hcd failed\n");
1377 goto remove_usb2_hcd;
1378 }
1379
1380 ret = usb_add_hcd(hcd_ss, 0, 0);
1381 if (ret) {
1382 pr_err("usb_add_hcd ss failed %d\n", ret);
1383 goto put_usb3_hcd;
1384 }
1385
1386 usbip_dbg_vhci_hc("bye\n");
1387 return 0;
1388
1389 put_usb3_hcd:
1390 usb_put_hcd(hcd_ss);
1391 remove_usb2_hcd:
1392 usb_remove_hcd(hcd_hs);
1393 put_usb2_hcd:
1394 usb_put_hcd(hcd_hs);
1395 vhci->vhci_hcd_hs = NULL;
1396 vhci->vhci_hcd_ss = NULL;
1397 return ret;
1398 }
1399
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-04-23 1:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 9:25 [PATCH] usbip: Fix the error limitation on max_hw_sectors for usbip device Zongmin Zhou
2025-02-21 16:37 ` Shuah Khan
[not found] ` <5a41d6c3.8c78.195371996e0.Coremail.min_halo@163.com>
2025-02-27 22:23 ` Shuah Khan
[not found] ` <4d4035bf.26b9.19556dcc23d.Coremail.min_halo@163.com>
2025-03-04 19:45 ` Shuah Khan
[not found] ` <6d47fef6.9eef.19565c308e5.Coremail.min_halo@163.com>
2025-03-10 16:49 ` Shuah Khan
2025-03-13 10:02 ` Zongmin Zhou
2025-03-28 21:14 ` Shuah Khan
2025-04-02 8:34 ` Zongmin Zhou
2025-04-08 22:54 ` Shuah Khan
2025-04-22 6:34 ` [PATCH] usbip: set the dma mask to 64bit default for vhci-driver Zongmin Zhou
2025-04-22 6:40 ` Greg KH
2025-04-22 7:24 ` Christoph Hellwig
2025-04-25 8:08 ` Zongmin Zhou
2025-04-25 8:28 ` Greg KH
2025-04-28 9:51 ` Zongmin Zhou
2025-04-28 10:04 ` Greg KH
2025-04-28 23:07 ` Shuah Khan
2025-04-30 5:24 ` Zongmin Zhou
2025-04-30 7:31 ` Greg KH
2025-04-23 1:02 ` kernel test robot [this message]
2025-04-23 7:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202504230805.MkmxQyas-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=min_halo@163.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=valentina.manea.m@gmail.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).