From: Greg KH <gregkh@linuxfoundation.org>
To: Zongmin Zhou <min_halo@163.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>,
i@zenithal.me, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, shuah@kernel.org,
valentina.manea.m@gmail.com,
Zongmin Zhou <zhouzongmin@kylinos.cn>
Subject: Re: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver
Date: Mon, 28 Apr 2025 12:04:17 +0200 [thread overview]
Message-ID: <2025042812-sinister-shaping-bded@gregkh> (raw)
In-Reply-To: <575ce02c-9128-4098-a852-d9e14f14010e@163.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Apr 28, 2025 at 05:51:08PM +0800, Zongmin Zhou wrote:
> Dear Greg and Shuah,
>
> I found out that the vhci-hcd driver added this virtual device
> as a platform device from the very beginning since 2014.
Ah, I should have caught it back then, but at the time there really
wasn't another option.
> I'm just getting in touch with this module and
> don't have a deep understanding of it,shuah should be clearer.
See the recent patches I did converting drivers to use the faux bus
code, it should be pretty simple to do.
> I don't know if using the faux bus to replace the platform bus can solve the
> problem that the error limitation on max_hw_sectors for usbip device
> since commit d74ffae8b8dd applied.
That is for the storage driver, not usbip. As the faux bus does not
have any real dma operations, this should cause it to work properly
given the default values involed, but that's up to you to test to verify
it does just that. Try it and see!
> But this change will request user to update kernel version to support faux
> bus.
That's just a normal kernel update to a newer version, what is wrong
with that?
> This will also be an expensive change to fix the problem?
Fixing things properly is the correct thing to do in all cases.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-28 10:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 9:25 [PATCH] usbip: Fix the error limitation on max_hw_sectors for usbip device Zongmin Zhou
2025-02-21 16:37 ` Shuah Khan
[not found] ` <5a41d6c3.8c78.195371996e0.Coremail.min_halo@163.com>
2025-02-27 22:23 ` Shuah Khan
[not found] ` <4d4035bf.26b9.19556dcc23d.Coremail.min_halo@163.com>
2025-03-04 19:45 ` Shuah Khan
[not found] ` <6d47fef6.9eef.19565c308e5.Coremail.min_halo@163.com>
2025-03-10 16:49 ` Shuah Khan
2025-03-13 10:02 ` Zongmin Zhou
2025-03-28 21:14 ` Shuah Khan
2025-04-02 8:34 ` Zongmin Zhou
2025-04-08 22:54 ` Shuah Khan
2025-04-22 6:34 ` [PATCH] usbip: set the dma mask to 64bit default for vhci-driver Zongmin Zhou
2025-04-22 6:40 ` Greg KH
2025-04-22 7:24 ` Christoph Hellwig
2025-04-25 8:08 ` Zongmin Zhou
2025-04-25 8:28 ` Greg KH
2025-04-28 9:51 ` Zongmin Zhou
2025-04-28 10:04 ` Greg KH [this message]
2025-04-28 23:07 ` Shuah Khan
2025-04-30 5:24 ` Zongmin Zhou
2025-04-30 7:31 ` Greg KH
2025-04-23 1:02 ` kernel test robot
2025-04-23 7:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025042812-sinister-shaping-bded@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=min_halo@163.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=valentina.manea.m@gmail.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox